Move afterUninstall into api.ts & improvements

Author: iamEvanYT

packages/electron-chrome-web-store/README.md

@@ -101,7 +101,7 @@ Installs Chrome Web Store support in the specified session.
   - `denylist`: An array of denied extension IDs to install.
   - `beforeInstall`: A function which receives install details and returns a promise. Allows for prompting prior to install.
   - `afterInstall`: A function which receives install details. Allows for additional actions after install.
-  - `afterUninstall`: A function which receives extension ID, extension, and manifest. Allows for additional actions after uninstall.
+  - `afterUninstall`: A function which receives extension ID. Allows for additional actions after uninstall.
   - `overrideExtensionInstallStatus`: A function which receives the current state, extension ID, and manifest. Returns a string indicating the install status of the extension, or returns undefined to fallback to the default install status.
 
 ### `installExtension`

packages/electron-chrome-web-store/src/browser/api.ts

@@ -331,9 +331,17 @@ export function registerWebStoreApi(webStoreState: WebStoreState) {
 
       try {
         await uninstallExtension(id, webStoreState)
+
         queueMicrotask(() => {
           event.sender.send('chrome.management.onUninstalled', id)
         })
+
+        if (webStoreState.afterUninstall) {
+          queueMicrotask(() => {
+            webStoreState.afterUninstall?.({ id })
+          })
+        }
+
         return Result.SUCCESS
       } catch (error) {
         console.error(error)

packages/electron-chrome-web-store/src/browser/installer.ts

@@ -203,11 +203,6 @@ interface InstallExtensionOptions extends CommonExtensionOptions {
   loadExtensionOptions?: Electron.LoadExtensionOptions
 }
 
-interface UninstallExtensionOptions extends CommonExtensionOptions {
-  /** Called after an extension is uninstalled. */
-  afterUninstall?: AfterUninstall
-}
-
 /**
  * Install extension from the web store.
  */
@@ -245,10 +240,7 @@ export async function installExtension(
 /**
  * Uninstall extension from the web store.
  */
-export async function uninstallExtension(
-  extensionId: string,
-  opts: UninstallExtensionOptions = {},
-) {
+export async function uninstallExtension(extensionId: string, opts: CommonExtensionOptions = {}) {
   d('uninstalling %s', extensionId)
 
   const session = opts.session || electronSession.defaultSession
@@ -260,14 +252,6 @@ export async function uninstallExtension(
     session.removeExtension(extensionId)
   }
 
-  if (opts.afterUninstall) {
-    await opts.afterUninstall({
-      id: extensionId,
-      extension: existingExt,
-      manifest: existingExt?.manifest,
-    })
-  }
-
   const extensionDir = path.join(extensionsPath, extensionId)
   try {
     const stat = await fs.promises.stat(extensionDir)

packages/electron-chrome-web-store/src/browser/types.ts

@@ -15,11 +15,7 @@ export type BeforeInstall = (
 
 export type AfterInstall = (details: ExtensionInstallDetails) => Promise<void>
 
-export type AfterUninstall = (details: {
-  id: ExtensionId
-  extension?: Electron.Extension
-  manifest?: chrome.runtime.Manifest
-}) => Promise<void>
+export type AfterUninstall = (details: { id: ExtensionId }) => Promise<void>
 
 export type CustomSetExtensionEnabled = (
   state: WebStoreState,