Skip to content

Commit f93aae3

Browse files
Address review comments: Permission changes and removed mount docker socket
1 parent 2bbaf3b commit f93aae3

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

.github/scripts/ppc64le-ci/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ $ cd pytorch
2424
$ git submodule update --init --recursive
2525
$ GPU_ARCH_TYPE=cpu-ppc64le "$(pwd)/.ci/docker/manywheel/build.sh" ubippc64le-builder
2626
$ docker image tag localhost/pytorch/ubippc64le-builder docker.io/pytorch/ubippc64le-builder:cpu-ppc64le
27-
$ docker image save -o ~/ubi-ppc64le.tar docker.io/pytorch/ubippc64le-builder:cpu-ppc64le
27+
$ docker image save -o ~/pytorch-ubi-ppc64le.tar docker.io/pytorch/ubippc64le-builder:cpu-ppc64le
2828
```
2929

3030
Next step is to build `actions-runner` image using:

.github/scripts/ppc64le-ci/self-hosted-builder/actions-runner.Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,11 @@ RUN mkdir -p /opt/runner && \
8484
chown -R runner:runner /opt/runner && \
8585
su - runner -c "/opt/runner/config.sh --version"
8686

87-
RUN rm -rf /tmp/runner /tmp/runner.patch
87+
RUN rm -rf /tmp/runner /tmp/runner.patch
8888

8989
# Copy custom scripts and set permissions
9090
COPY fs/ /
91-
RUN chmod 777 /usr/bin/actions-runner /usr/bin/entrypoint
91+
RUN chmod +x /usr/bin/actions-runner /usr/bin/entrypoint
9292

9393
# Switch to the runner user
9494
USER runner

.github/scripts/ppc64le-ci/self-hosted-builder/[email protected]

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ ExecStartPre=-/usr/local/bin/gh_cat_token.sh /etc/actions-runner/%i/ghtoken.env
1414
ExecStart=/usr/bin/docker run \
1515
--env-file=/etc/actions-runner/%i/env \
1616
--volume /etc/actions-runner/%i/ghtoken.txt:/run/runner_secret \
17-
--volume /var/run/docker.sock:/var/run/docker.sock \
1817
--init \
1918
--interactive \
2019
--name=actions-runner.%i \

0 commit comments

Comments
 (0)