Skip to content

Commit 08edae7

Browse files
diemolsandeepsuryaprasad
authored andcommitted
[js] Removing TODO
Closes SeleniumHQ#14490
1 parent b125917 commit 08edae7

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

javascript/private/gen_file.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919
"""
2020

2121
def get_atom_name(name):
22-
# TODO: Convert camelCase and snake_case to BIG_SNAKE_CASE
22+
# We had a todo here to convert camelCase and snake_case to BIG_SNAKE_CASE, but this code
23+
# will be removed when BiDi is the default, so we're not going to bother with that.
2324
name = os.path.basename(name)
2425
return name.upper()
2526

@@ -76,7 +77,7 @@ def generate_header(file_name, out, js_map, just_declare, utf8):
7677
define_guard = "WEBDRIVER_%s" % os.path.basename(file_name.upper()).replace(".", "_")
7778
include_stddef = "" if utf8 else "\n#include <stddef.h> // For wchar_t."
7879
out.write("""%s
79-
80+
8081
/* AUTO GENERATED - DO NOT EDIT BY HAND */
8182
#ifndef %s
8283
#define %s
@@ -85,12 +86,12 @@ def generate_header(file_name, out, js_map, just_declare, utf8):
8586
8687
namespace webdriver {
8788
namespace atoms {
88-
89+
8990
""" % (_copyright, define_guard, define_guard, include_stddef))
9091

9192
string_type = "std::string" if utf8 else "std::wstring"
9293
char_type = "char" if utf8 else "wchar_t"
93-
94+
9495
for (name, file) in js_map.items():
9596
if just_declare:
9697
out.write("extern const %s* const %s[];\n" % (char_type, name.upper()))
@@ -109,7 +110,7 @@ def generate_header(file_name, out, js_map, just_declare, utf8):
109110
110111
} // namespace atoms
111112
} // namespace webdriver
112-
113+
113114
#endif // %s
114115
""" % (string_type, char_type, string_type, define_guard))
115116

@@ -123,7 +124,7 @@ def generate_cc_source(out, js_map, utf8):
123124
124125
namespace webdriver {
125126
namespace atoms {
126-
127+
127128
""" % _copyright)
128129

129130
for (name, file) in js_map.items():

0 commit comments

Comments
 (0)