Skip to content

Commit 7ccca71

Browse files
titusfortnersandeepsuryaprasad
authored andcommitted
[build] rename skip-remote to skip-rbe
differentiate this tag from "remote" which is used to indicate when a test uses the grid
1 parent 23219b9 commit 7ccca71

File tree

6 files changed

+18
-18
lines changed

6 files changed

+18
-18
lines changed

.bazelrc.remote

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ build:remote --disk_cache=
3131
build:remote --incompatible_enable_cc_toolchain_resolution
3232
build:remote --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
3333
test:remote --test_env=DISPLAY=:99.0
34-
test:remote --test_tag_filters=-exclusive-if-local,-skip-remote,-remote
34+
test:remote --test_tag_filters=-exclusive-if-local,-skip-rbe,-remote
3535

3636
# Env vars we can hard code
3737
build:remote --action_env=HOME=/home/dev

dotnet/private/dotnet_nunit_test_suite.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ _BROWSERS = {
7878
],
7979
}),
8080
"data": [],
81-
"tags": ["skip-remote"],
81+
"tags": ["skip-rbe"],
8282
},
8383
"safari": {
8484
"args": [
@@ -90,7 +90,7 @@ _BROWSERS = {
9090
],
9191
}),
9292
"data": [],
93-
"tags": ["skip-remote"],
93+
"tags": ["skip-rbe"],
9494
},
9595
}
9696

java/private/selenium_test.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ BROWSERS = {
5050
"@selenium//conditions:default": ["-Dselenium.skiptest=true"],
5151
}),
5252
"data": [],
53-
"tags": COMMON_TAGS + ["exclusive-if-local", "ie", "skip-remote"],
53+
"tags": COMMON_TAGS + ["exclusive-if-local", "ie", "skip-rbe"],
5454
},
5555
"safari": {
5656
"deps": ["//java/src/org/openqa/selenium/safari"],
@@ -60,7 +60,7 @@ BROWSERS = {
6060
"@selenium//conditions:default": ["-Dselenium.skiptest=true"],
6161
}),
6262
"data": [],
63-
"tags": COMMON_TAGS + ["exclusive-if-local", "safari", "skip-remote"],
63+
"tags": COMMON_TAGS + ["exclusive-if-local", "safari", "skip-rbe"],
6464
},
6565
}
6666

py/BUILD.bazel

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ compile_pip_requirements(
5858
requirements_in = ":requirements.txt",
5959
requirements_txt = ":requirements_lock.txt",
6060
tags = [
61-
"skip-remote", # This test won't run on the RBE because of a lack of network connectivity
61+
"skip-rbe", # This test won't run on the RBE because of a lack of network connectivity
6262
],
6363
)
6464

@@ -486,7 +486,7 @@ py_test_suite(
486486
env_inherit = ["DISPLAY"],
487487
tags = [
488488
"no-sandbox",
489-
"skip-remote",
489+
"skip-rbe",
490490
] + BROWSERS["chrome"]["tags"],
491491
deps = [
492492
":init-tree",
@@ -533,7 +533,7 @@ py_test_suite(
533533
env_inherit = ["DISPLAY"],
534534
tags = [
535535
"no-sandbox",
536-
"skip-remote",
536+
"skip-rbe",
537537
] + BROWSERS["firefox"]["tags"],
538538
deps = [
539539
":init-tree",
@@ -561,7 +561,7 @@ py_test_suite(
561561
],
562562
tags = [
563563
"no-sandbox",
564-
"skip-remote",
564+
"skip-rbe",
565565
],
566566
deps = [
567567
":init-tree",
@@ -584,7 +584,7 @@ py_test_suite(
584584
],
585585
tags = [
586586
"no-sandbox",
587-
"skip-remote",
587+
"skip-rbe",
588588
],
589589
deps = [
590590
":init-tree",
@@ -606,7 +606,7 @@ py_test_suite(
606606
tags = [
607607
"exclusive-if-local",
608608
"no-sandbox",
609-
"skip-remote",
609+
"skip-rbe",
610610
],
611611
deps = [
612612
":init-tree",
@@ -631,7 +631,7 @@ py_test_suite(
631631
tags = [
632632
"exclusive-if-local",
633633
"no-sandbox",
634-
"skip-remote",
634+
"skip-rbe",
635635
],
636636
deps = [
637637
":init-tree",
@@ -656,7 +656,7 @@ py_test_suite(
656656
tags = [
657657
"exclusive-if-local",
658658
"no-sandbox",
659-
"skip-remote",
659+
"skip-rbe",
660660
],
661661
deps = [
662662
":init-tree",

py/private/browsers.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,11 @@ BROWSERS = {
7272
"ie": {
7373
"args": ["--driver=ie"],
7474
"data": [],
75-
"tags": COMMON_TAGS + ["ie", "skip-remote"],
75+
"tags": COMMON_TAGS + ["ie", "skip-rbe"],
7676
},
7777
"safari": {
7878
"args": ["--driver=safari"],
7979
"data": [],
80-
"tags": COMMON_TAGS + ["safari", "skip-remote"],
80+
"tags": COMMON_TAGS + ["safari", "skip-rbe"],
8181
},
8282
}

rb/spec/tests.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ BROWSERS = {
105105
"data": [],
106106
"deps": ["//rb/lib/selenium/webdriver:ie"],
107107
"tags": [
108-
"skip-remote", # RBE is Linux-only.
108+
"skip-rbe", # RBE is Linux-only.
109109
],
110110
"target_compatible_with": ["@platforms//os:windows"],
111111
"env": {
@@ -118,7 +118,7 @@ BROWSERS = {
118118
"deps": ["//rb/lib/selenium/webdriver:safari"],
119119
"tags": [
120120
"exclusive-if-local", # Safari cannot run in parallel.
121-
"skip-remote", # RBE is Linux-only.
121+
"skip-rbe", # RBE is Linux-only.
122122
],
123123
"target_compatible_with": ["@platforms//os:macos"],
124124
"env": {
@@ -131,7 +131,7 @@ BROWSERS = {
131131
"deps": ["//rb/lib/selenium/webdriver:safari"],
132132
"tags": [
133133
"exclusive-if-local", # Safari cannot run in parallel.
134-
"skip-remote", # RBE is Linux-only.
134+
"skip-rbe", # RBE is Linux-only.
135135
],
136136
"target_compatible_with": ["@platforms//os:macos"],
137137
"env": {

0 commit comments

Comments
 (0)