Skip to content

Commit a8ef660

Browse files
titusfortnersandeepsuryaprasad
authored andcommitted
[rb] fix test failures on RBE by restarting sessions between tests
Regular failures began with Chrome 134 and this prevents them it is not ideal for performance reasons, and we should look into a better solution
1 parent a61a7cf commit a8ef660

File tree

4 files changed

+12
-1
lines changed

4 files changed

+12
-1
lines changed

rb/spec/integration/selenium/webdriver/driver_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
module Selenium
2323
module WebDriver
2424
describe Driver, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
25+
after { reset_driver! if GlobalTestEnv.rbe? && GlobalTestEnv.browser == :chrome }
26+
2527
it_behaves_like 'driver that can be started concurrently', exclude: [
2628
{browser: %i[safari safari_preview]},
2729
{browser: :firefox, reason: 'https://github.com/SeleniumHQ/selenium/issues/15451'},

rb/spec/integration/selenium/webdriver/manager_spec.rb

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,13 @@ module WebDriver
2525
describe 'cookie management' do
2626
before { driver.navigate.to url_for('xhtmlTest.html') }
2727

28-
after { driver.manage.delete_all_cookies }
28+
after do
29+
if GlobalTestEnv.rbe? && GlobalTestEnv.browser == :chrome
30+
reset_driver!
31+
else
32+
driver.manage.delete_all_cookies
33+
end
34+
end
2935

3036
it 'sets correct defaults' do
3137
driver.manage.add_cookie name: 'default',

rb/spec/integration/selenium/webdriver/select_spec.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ module Support
2929
let(:multi_disabled) { described_class.new(driver.find_element(name: 'multi_disabled')) }
3030

3131
before { driver.navigate.to url_for('formPage.html') }
32+
after { reset_driver! if GlobalTestEnv.rbe? && GlobalTestEnv.browser == :chrome }
3233

3334
describe '#initialize' do
3435
it 'raises exception if not a select element' do

rb/spec/integration/selenium/webdriver/target_locator_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ module WebDriver
3131
(handles - [driver.window_handle]).each do |handle|
3232
driver.switch_to.window(handle) { driver.close }
3333
end
34+
rescue Selenium::WebDriver::Error::WebDriverError
35+
reset_driver!
3436
end
3537

3638
let(:new_window) { driver.window_handles.find { |handle| handle != driver.window_handle } }

0 commit comments

Comments
 (0)