Skip to content

Commit f9cbebc

Browse files
pujaganisandeepsuryaprasad
authored andcommitted
[java] Avoid augmenting CDP for Firefox (SeleniumHQ#15271)
1 parent f8a5cb3 commit f9cbebc

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

java/src/org/openqa/selenium/devtools/CdpEndpointFinder.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,6 @@ public static Optional<URI> getReportedUri(Capabilities caps) {
8989
case "msedge":
9090
key = "ms:edgeOptions";
9191
break;
92-
case "firefox":
93-
key = "moz:debuggerAddress";
94-
if (!caps.is("webSocketUrl")) {
95-
LOG.warning(
96-
"CDP support for Firefox is deprecated and will be removed in future versions. "
97-
+ "Please switch to WebDriver BiDi.");
98-
}
99-
break;
10092
default:
10193
return Optional.empty();
10294
}

java/src/org/openqa/selenium/firefox/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ java_export(
1313
deps = [
1414
"//java:auto-service",
1515
"//java/src/org/openqa/selenium/bidi",
16-
"//java/src/org/openqa/selenium/devtools/v85",
1716
"//java/src/org/openqa/selenium/json",
1817
"//java/src/org/openqa/selenium/manager",
1918
"//java/src/org/openqa/selenium/remote",

java/test/org/openqa/selenium/remote/RemoteWebDriverBuilderTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -490,13 +490,13 @@ public URL getUrl() {
490490
SESSION_ID,
491491
"capabilities",
492492
new ImmutableCapabilities(
493-
"firefox", "caps",
494-
"browserName", "firefox",
495-
"moz:debuggerAddress", uri.toString())))));
493+
"chrome", "caps",
494+
"browserName", "chrome",
495+
"goog:chromeOptions", uri.toString())))));
496496

497497
WebDriver driver =
498498
RemoteWebDriver.builder()
499-
.oneOf(new FirefoxOptions())
499+
.oneOf(new ChromeOptions())
500500
.withDriverService(service)
501501
.augmentUsing(new Augmenter())
502502
.connectingWith(config -> req -> response)

0 commit comments

Comments
 (0)