Remove code from OpenApiRouteHandlerBUilderExtensions based on Safiaś comment

Also removed new constructors based on Safiaś comment

Author: sander1095

src/Http/Http.Abstractions/src/Metadata/IProducesResponseTypeMetadata.cs

@@ -21,7 +21,7 @@ public interface IProducesResponseTypeMetadata
     /// <summary>
     /// Gets the description of the response.
     /// </summary>
-    string? Description { get; }
+    string? Description { get; set; }
 
     /// <summary>
     /// Gets the content types supported by the metadata.

src/Http/Http.Abstractions/src/Metadata/ProducesResponseTypeMetadata.cs

@@ -21,12 +21,10 @@ public sealed class ProducesResponseTypeMetadata : IProducesResponseTypeMetadata
     /// <param name="statusCode">The HTTP response status code.</param>
     /// <param name="type">The <see cref="Type"/> of object that is going to be written in the response.</param>
     /// <param name="contentTypes">Content types supported by the response.</param>
-    /// <param name="description">The description of the response.</param>
-    public ProducesResponseTypeMetadata(int statusCode, Type? type = null, string[]? contentTypes = null, string? description = null)
+    public ProducesResponseTypeMetadata(int statusCode, Type? type = null, string[]? contentTypes = null)
     {
         StatusCode = statusCode;
         Type = type;
-        Description = description;
 
         if (contentTypes is null || contentTypes.Length == 0)
         {
@@ -52,22 +50,12 @@ static void ValidateContentType(string type)
         }
     }
 
-    // 9.0 BACKCOMPAT OVERLOAD -- DO NOT TOUCH
-    /// <summary>
-    /// Initializes an instance of <see cref="ProducesResponseTypeMetadata"/>.
-    /// </summary>
-    /// <param name="statusCode">The HTTP response status code.</param>
-    /// <param name="type">The <see cref="Type"/> of object that is going to be written in the response.</param>
-    /// <param name="contentTypes">Content types supported by the response.</param>
-    public ProducesResponseTypeMetadata(int statusCode, Type? type = null, string[]? contentTypes = null) : this(statusCode, type, contentTypes, description: null) { }
-
     // Only for internal use where validation is unnecessary.
-    private ProducesResponseTypeMetadata(int statusCode, Type? type, IEnumerable<string> contentTypes, string? description = null)
+    private ProducesResponseTypeMetadata(int statusCode, Type? type, IEnumerable<string> contentTypes)
     {
         Type = type;
         StatusCode = statusCode;
         ContentTypes = contentTypes;
-        Description = description;
     }
 
     /// <summary>
@@ -83,7 +71,7 @@ private ProducesResponseTypeMetadata(int statusCode, Type? type, IEnumerable<str
     /// <summary>
     /// Gets or sets the description of the response.
     /// </summary>
-    public string? Description { get; private set; }
+    public string? Description { get; set; }
 
     /// <summary>
     /// Gets or sets the content types associated with the response.
@@ -96,5 +84,5 @@ public override string ToString()
         return DebuggerHelpers.GetDebugText(nameof(StatusCode), StatusCode, nameof(ContentTypes), ContentTypes, nameof(Type), Type, includeNullValues: false, prefix: "Produces");
     }
 
-    internal static ProducesResponseTypeMetadata CreateUnvalidated(Type? type, int statusCode, IEnumerable<string> contentTypes, string? description) => new(statusCode, type, contentTypes, description);
+    internal static ProducesResponseTypeMetadata CreateUnvalidated(Type? type, int statusCode, IEnumerable<string> contentTypes) => new(statusCode, type, contentTypes);
 }

src/Http/Http.Abstractions/src/PublicAPI.Shipped.txt

@@ -413,7 +413,6 @@ Microsoft.AspNetCore.Http.ProblemDetailsContext.ProblemDetails.set -> void
 Microsoft.AspNetCore.Http.ProblemDetailsContext.ProblemDetailsContext() -> void
 Microsoft.AspNetCore.Http.ProducesResponseTypeMetadata
 Microsoft.AspNetCore.Http.ProducesResponseTypeMetadata.ContentTypes.get -> System.Collections.Generic.IEnumerable<string!>!
-Microsoft.AspNetCore.Http.ProducesResponseTypeMetadata.ProducesResponseTypeMetadata(int statusCode, System.Type? type = null, string![]? contentTypes = null) -> void
 Microsoft.AspNetCore.Http.ProducesResponseTypeMetadata.StatusCode.get -> int
 Microsoft.AspNetCore.Http.ProducesResponseTypeMetadata.Type.get -> System.Type?
 Microsoft.AspNetCore.Http.QueryString

src/Http/Http.Abstractions/src/PublicAPI.Unshipped.txt

@@ -12,6 +12,7 @@ Microsoft.AspNetCore.Http.Metadata.IParameterBindingMetadata.IsOptional.get -> b
 Microsoft.AspNetCore.Http.Metadata.IParameterBindingMetadata.Name.get -> string!
 Microsoft.AspNetCore.Http.Metadata.IParameterBindingMetadata.ParameterInfo.get -> System.Reflection.ParameterInfo!
 Microsoft.AspNetCore.Http.ProducesResponseTypeMetadata.Description.get -> string?
+Microsoft.AspNetCore.Http.ProducesResponseTypeMetadata.Description.set -> void
 Microsoft.AspNetCore.Http.Metadata.IProducesResponseTypeMetadata.Description.get -> string?
-*REMOVED*Microsoft.AspNetCore.Http.ProducesResponseTypeMetadata.ProducesResponseTypeMetadata(int statusCode, System.Type? type = null, string![]? contentTypes = null) -> void
-Microsoft.AspNetCore.Http.ProducesResponseTypeMetadata.ProducesResponseTypeMetadata(int statusCode, System.Type? type = null, string![]? contentTypes = null, string? description = null) -> void
+Microsoft.AspNetCore.Http.Metadata.IProducesResponseTypeMetadata.Description.set -> void
+Microsoft.AspNetCore.Http.ProducesResponseTypeMetadata.ProducesResponseTypeMetadata(int statusCode, System.Type? type = null, string![]? contentTypes = null) -> void

src/Http/Http.Extensions/src/RequestDelegateFactory.cs

@@ -1039,15 +1039,15 @@ private static void PopulateBuiltInResponseTypeMetadata(Type returnType, Endpoin
 
         if (returnType == typeof(string))
         {
-            builder.Metadata.Add(ProducesResponseTypeMetadata.CreateUnvalidated(type: typeof(string), statusCode: 200, PlaintextContentType, description: null));
+            builder.Metadata.Add(ProducesResponseTypeMetadata.CreateUnvalidated(type: typeof(string), statusCode: 200, PlaintextContentType));
         }
         else if (returnType == typeof(void))
         {
-            builder.Metadata.Add(ProducesResponseTypeMetadata.CreateUnvalidated(returnType, statusCode: 200, PlaintextContentType), description: null);
+            builder.Metadata.Add(ProducesResponseTypeMetadata.CreateUnvalidated(returnType, statusCode: 200, PlaintextContentType));
         }
         else
         {
-            builder.Metadata.Add(ProducesResponseTypeMetadata.CreateUnvalidated(returnType, statusCode: 200, DefaultAcceptsAndProducesContentType), description: null);
+            builder.Metadata.Add(ProducesResponseTypeMetadata.CreateUnvalidated(returnType, statusCode: 200, DefaultAcceptsAndProducesContentType));
         }
     }
 

src/Http/Http.Results/src/AcceptedAtRouteOfT.cs

@@ -122,6 +122,6 @@ static void IEndpointMetadataProvider.PopulateMetadata(MethodInfo method, Endpoi
         ArgumentNullException.ThrowIfNull(method);
         ArgumentNullException.ThrowIfNull(builder);
 
-        builder.Metadata.Add(ProducesResponseTypeMetadata.CreateUnvalidated(typeof(TValue), StatusCodes.Status202Accepted, ContentTypeConstants.ApplicationJsonContentTypes, description: null));
+        builder.Metadata.Add(ProducesResponseTypeMetadata.CreateUnvalidated(typeof(TValue), StatusCodes.Status202Accepted, ContentTypeConstants.ApplicationJsonContentTypes));
     }
 }

src/Http/Http.Results/src/AcceptedOfT.cs

@@ -100,6 +100,6 @@ static void IEndpointMetadataProvider.PopulateMetadata(MethodInfo method, Endpoi
         ArgumentNullException.ThrowIfNull(method);
         ArgumentNullException.ThrowIfNull(builder);
 
-        builder.Metadata.Add(ProducesResponseTypeMetadata.CreateUnvalidated(typeof(TValue), StatusCodes.Status202Accepted, ContentTypeConstants.ApplicationJsonContentTypes, description: null));
+        builder.Metadata.Add(ProducesResponseTypeMetadata.CreateUnvalidated(typeof(TValue), StatusCodes.Status202Accepted, ContentTypeConstants.ApplicationJsonContentTypes));
     }
 }

src/Http/Http.Results/src/BadRequestOfT.cs

@@ -65,6 +65,6 @@ static void IEndpointMetadataProvider.PopulateMetadata(MethodInfo method, Endpoi
         ArgumentNullException.ThrowIfNull(method);
         ArgumentNullException.ThrowIfNull(builder);
 
-        builder.Metadata.Add(ProducesResponseTypeMetadata.CreateUnvalidated(typeof(TValue), StatusCodes.Status400BadRequest, ContentTypeConstants.ApplicationJsonContentTypes, description: null));
+        builder.Metadata.Add(ProducesResponseTypeMetadata.CreateUnvalidated(typeof(TValue), StatusCodes.Status400BadRequest, ContentTypeConstants.ApplicationJsonContentTypes));
     }
 }

src/Http/Http.Results/src/ConflictOfT.cs

@@ -65,6 +65,6 @@ static void IEndpointMetadataProvider.PopulateMetadata(MethodInfo method, Endpoi
         ArgumentNullException.ThrowIfNull(method);
         ArgumentNullException.ThrowIfNull(builder);
 
-        builder.Metadata.Add(ProducesResponseTypeMetadata.CreateUnvalidated(typeof(TValue), StatusCodes.Status409Conflict, ContentTypeConstants.ApplicationJsonContentTypes, description: null));
+        builder.Metadata.Add(ProducesResponseTypeMetadata.CreateUnvalidated(typeof(TValue), StatusCodes.Status409Conflict, ContentTypeConstants.ApplicationJsonContentTypes));
     }
 }

src/Http/Http.Results/src/CreatedAtRouteOfT.cs

@@ -125,6 +125,6 @@ static void IEndpointMetadataProvider.PopulateMetadata(MethodInfo method, Endpoi
         ArgumentNullException.ThrowIfNull(method);
         ArgumentNullException.ThrowIfNull(builder);
 
-        builder.Metadata.Add(ProducesResponseTypeMetadata.CreateUnvalidated(typeof(TValue), StatusCodes.Status201Created, ContentTypeConstants.ApplicationJsonContentTypes, description: null));
+        builder.Metadata.Add(ProducesResponseTypeMetadata.CreateUnvalidated(typeof(TValue), StatusCodes.Status201Created, ContentTypeConstants.ApplicationJsonContentTypes));
     }
 }