fix + tests for get_documents

Author: Kiraprint

meilisearch_python_sdk/index.py

@@ -1371,6 +1371,9 @@ async def get_documents(
             "limit": limit,
         }
 
+        if retrieve_vectors:
+            parameters["retrieveVectors"] = "true"
+
         if not filter:
             if fields:
                 parameters["fields"] = ",".join(fields)
@@ -1382,8 +1385,6 @@ async def get_documents(
 
         if fields:
             parameters["fields"] = fields
-        if retrieve_vectors:
-            parameters["retrieveVectors"] = retrieve_vectors
 
         parameters["filter"] = filter
 
@@ -5577,6 +5578,9 @@ def get_documents(
             "limit": limit,
         }
 
+        if retrieve_vectors:
+            parameters["retrieveVectors"] = "true"
+
         if not filter:
             if fields:
                 parameters["fields"] = ",".join(fields)
@@ -5588,8 +5592,6 @@ def get_documents(
 
         if fields:
             parameters["fields"] = fields
-        if retrieve_vectors:
-            parameters["retrieveVectors"] = retrieve_vectors
 
         parameters["filter"] = filter
         response = self._http_requests.post(f"{self._documents_url}/fetch", body=parameters)

tests/test_async_documents.py

@@ -758,6 +758,14 @@ async def test_get_documents_filter_with_fields(async_index_with_documents):
     assert next(iter(genres)) == "action"
 
 
+async def test_get_documents_with_vectors(async_index_with_documents):
+    index = await async_index_with_documents()
+    response = await index.update_filterable_attributes(["genre"])
+    await async_wait_for_task(index.http_client, response.task_uid)
+    response = await index.get_documents(retrieve_vectors=True)
+    assert all("_vectors" in x.keys() for x in response.results)
+
+
 @pytest.mark.parametrize("compress", (True, False))
 async def test_update_documents(compress, async_index_with_documents, small_movies):
     index = await async_index_with_documents()

tests/test_documents.py

@@ -666,6 +666,14 @@ def test_get_documents_filter(index_with_documents):
     assert next(iter(genres)) == "action"
 
 
+def test_get_documents_with_vectors(index_with_documents):
+    index = index_with_documents()
+    response = index.update_filterable_attributes(["genre"])
+    wait_for_task(index.http_client, response.task_uid)
+    response = index.get_documents(retrieve_vectors=True)
+    assert all("_vectors" in x.keys() for x in response.results)
+
+
 def test_get_documents_filter_with_fields(index_with_documents):
     index = index_with_documents()
     response = index.update_filterable_attributes(["genre"])