Merge pull request #625 from sanders41/raise-for-status

Add missing raise_for_stats when timeout is None

Author: sanders41

meilisearch_python_async/task.py

@@ -296,6 +296,8 @@ async def wait_for_task(
             response = await http_requests.get(url)
             status = TaskResult(**response.json())
             if status.status in ("succeeded", "failed"):
+                if raise_for_status and status.status == "failed":
+                    raise MeilisearchTaskFailedError(f"Task {task_id} failed")
                 return status
             await sleep(interval_in_ms / 1000)
 

tests/test_task.py

@@ -363,6 +363,37 @@ async def test_wait_for_task_raise_for_status_true(empty_index, small_movies):
     assert update.status == "succeeded"
 
 
+async def test_wait_for_task_raise_for_status_true_no_timeout(
+    empty_index, small_movies, base_url, monkeypatch
+):
+    async def mock_get_response(*args, **kwargs):
+        task = {
+            "uid": args[1].split("/")[1],
+            "index_uid": "7defe207-8165-4b69-8170-471456e295e0",
+            "status": "failed",
+            "task_type": "indexDeletion",
+            "details": {"deletedDocuments": 30},
+            "error": None,
+            "canceled_by": None,
+            "duration": "PT0.002765250S",
+            "enqueued_at": "2023-06-09T01:03:48.311936656Z",
+            "started_at": "2023-06-09T01:03:48.314143377Z",
+            "finished_at": "2023-06-09T01:03:48.316536088Z",
+        }
+
+        return httpx.Response(
+            200, json=task, request=httpx.Request("get", url=f"{base_url}/{args[1]}")
+        )
+
+    index = await empty_index()
+    response = await index.add_documents(small_movies)
+    monkeypatch.setattr(AsyncClient, "get", mock_get_response)
+    with pytest.raises(MeilisearchTaskFailedError):
+        await wait_for_task(
+            index.http_client, response.task_uid, raise_for_status=True, timeout_in_ms=None
+        )
+
+
 async def test_wait_for_task_raise_for_status_false(
     empty_index, small_movies, base_url, monkeypatch
 ):