Skip to content

Commit 164b05d

Browse files
committed
Reuse check_validity function
1 parent 5ef5556 commit 164b05d

File tree

3 files changed

+8
-16
lines changed

3 files changed

+8
-16
lines changed

src/core/codestream/ojph_codestream_local.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,8 @@ namespace ojph {
548548
ui32 num_comments)
549549
{
550550
//finalize
551-
siz.check_validity(cod);
551+
siz.set_cod(cod);
552+
siz.check_validity();
552553
cod.check_validity(siz);
553554
cod.update_atk(&atk);
554555
qcd.check_validity(siz, cod);

src/core/codestream/ojph_params.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -741,6 +741,8 @@ namespace ojph {
741741

742742
ws_kern_support_needed = (Rsiz & 0x20) != 0;
743743
dfs_support_needed = (Rsiz & 0x80) != 0;
744+
745+
check_validity();
744746
}
745747

746748
//////////////////////////////////////////////////////////////////////////

src/core/codestream/ojph_params_local.h

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -219,46 +219,35 @@ namespace ojph {
219219

220220
void set_image_extent(point dims)
221221
{
222-
if (dims.x == 0 || dims.y == 0)
223-
OJPH_ERROR(0x00040007, "image extent cannot be zero");
224-
if ((XOsiz != 0 && dims.x <= XOsiz) || (YOsiz != 0 && dims.y <= YOsiz))
225-
OJPH_ERROR(0x00040008,
226-
"image extent must be greater than image offset");
227222
Xsiz = dims.x;
228223
Ysiz = dims.y;
229224
}
230225

231226
void set_tile_size(size s)
232227
{
233-
if (s.w == 0 || s.h == 0)
234-
OJPH_ERROR(0x00040004, "tile size cannot be zero");
235228
XTsiz = s.w;
236229
YTsiz = s.h;
237230
}
238231

239232
void set_image_offset(point offset)
240233
{
241-
if ((Xsiz != 0 && offset.x >= Xsiz) ||
242-
(Ysiz != 0 && offset.y >= Ysiz))
243-
OJPH_ERROR(0x00040005,
244-
"image offset must be less than image extent");
245234
XOsiz = offset.x;
246235
YOsiz = offset.y;
247236
}
248237

249238
void set_tile_offset(point offset)
250239
{
251-
if (offset.x > XOsiz || offset.y > YOsiz)
252-
OJPH_ERROR(0x00040006,
253-
"tile offset must be no greater than image offset");
254240
XTOsiz = offset.x;
255241
YTOsiz = offset.y;
256242
}
257243

258-
void check_validity(const param_cod& cod)
244+
void set_cod(const param_cod& cod)
259245
{
260246
this->cod = &cod;
247+
}
261248

249+
void check_validity()
250+
{
262251
if (XTsiz == 0 && YTsiz == 0)
263252
{ XTsiz = Xsiz + XOsiz; YTsiz = Ysiz + YOsiz; }
264253
if (Xsiz == 0 || Ysiz == 0 || XTsiz == 0 || YTsiz == 0)

0 commit comments

Comments
 (0)