New assert occurs with v9.34 when instantiating an Omega_h::Library

[tristan0x]

I am surprised to notice this change that now expects argc and argv to not be nullptr:

omega_h/src/Omega_h_library.cpp

Lines 70 to 74 in 140c951

	OMEGA_H_CHECK(argc != nullptr);
	OMEGA_H_CHECK(argv != nullptr);
	for (int ic = 0; ic < *argc; ic++) {
	argv_.push_back((*argv)[ic]);
	}

... since Library provides a default constructor:

omega_h/src/Omega_h_library.hpp

Line 13 in 140c951

inline Library() : Library(nullptr, nullptr) {}

Blue Brain Project doesn't mind updating its usage to now passes argc and argv, but maybe introduce 2 breaking changes in Library API:

1. remove the Library default constructor
2. expect argc and argv to be rvalue, not pointers.

[ibaned]

@tristan0x my bad, it looks like I allowed in some changes that I shouldn't have. I will remove those asserts in a bit.