Merge pull request #19 from jorisvanandel/fix/administration-id-string-consistency

sandervanhooft · web-flow · commit fbfe337c8ea3 · 2025-03-26T11:49:59.000+01:00
[Fix] `administration_id` should always be a string
diff --git a/docs/src/content/docs/reference/contacts.md b/docs/src/content/docs/reference/contacts.md
@@ -245,7 +245,7 @@ When working with contacts, you'll have access to the following properties:
 | Property | Type | Description |
 |----------|------|-------------|
 | id | string | Unique identifier |
-| administration_id | integer | Administration ID |
+| administration_id | string | Administration ID |
 | company_name | string | Company name |
 | firstname | string | First name |
 | lastname | string | Last name |
diff --git a/docs/src/content/docs/reference/external-sales-invoice-payments.md b/docs/src/content/docs/reference/external-sales-invoice-payments.md
@@ -54,7 +54,7 @@ When working with external sales invoice payments, you'll have access to the fol
 | Property | Type | Description |
 |----------|------|-------------|
 | id | string | Unique identifier for the payment |
-| administration_id | int | ID of the administration the payment belongs to |
+| administration_id | string | ID of the administration the payment belongs to |
 | invoice_type | string | Type of invoice (always "ExternalSalesInvoice" for these payments) |
 | invoice_id | string | ID of the external sales invoice the payment is for |
 | financial_account_id | string | ID of the financial account the payment was made to |
diff --git a/docs/src/content/docs/reference/external-sales-invoices.md b/docs/src/content/docs/reference/external-sales-invoices.md
@@ -136,7 +136,7 @@ When working with external sales invoices, you'll have access to the following p
 | Property | Type | Description |
 |----------|------|-------------|
 | id | string | Unique identifier |
-| administration_id | integer | ID of the administration the invoice belongs to |
+| administration_id | string | ID of the administration the invoice belongs to |
 | contact_id | string | ID of the contact associated with the invoice |
 | contact | array | Contact details |
 | date | string | Date of the invoice (YYYY-MM-DD) |
diff --git a/docs/src/content/docs/reference/sales-invoices.md b/docs/src/content/docs/reference/sales-invoices.md
@@ -273,7 +273,7 @@ When working with sales invoices, you'll have access to the following properties
 | Property | Type | Description |
 |----------|------|-------------|
 | id | string | Unique identifier |
-| administration_id | int | ID of the administration the sales invoice belongs to |
+| administration_id | string | ID of the administration the sales invoice belongs to |
 | contact_id | string | ID of the contact associated with the sales invoice |
 | contact | array | Contact information |
 | contact_person_id | string | ID of the contact person |
diff --git a/docs/src/content/docs/reference/subscription-templates.md b/docs/src/content/docs/reference/subscription-templates.md
@@ -86,7 +86,7 @@ When working with subscription templates, you'll have access to the following pr
 | Property | Type | Description |
 |----------|------|-------------|
 | id | string | Unique identifier |
-| administration_id | int | ID of the administration the template belongs to |
+| administration_id | string | ID of the administration the template belongs to |
 | workflow_id | string | ID of the workflow to use for the subscription |
 | document_style_id | string | ID of the document style |
 | mergeable | boolean | Whether the template can be merged with other templates |
diff --git a/docs/src/content/docs/reference/subscriptions.md b/docs/src/content/docs/reference/subscriptions.md
@@ -111,7 +111,7 @@ When working with subscriptions, you'll have access to the following properties:
 | Property | Type | Description |
 |----------|------|-------------|
 | id | string | Unique identifier |
-| administration_id | int | ID of the administration the subscription belongs to |
+| administration_id | string | ID of the administration the subscription belongs to |
 | start_date | string | Date when the subscription starts |
 | end_date | string | Date when the subscription ends (null if ongoing) |
 | frequency | int | Frequency number (e.g., 1, 3, 6) |
diff --git a/docs/src/content/docs/reference/tax-rates.md b/docs/src/content/docs/reference/tax-rates.md
@@ -46,7 +46,7 @@ When working with tax rates, you'll have access to the following properties:
 | Property | Type | Description |
 |----------|------|-------------|
 | id | string | Unique identifier |
-| administration_id | int | ID of the administration the tax rate belongs to |
+| administration_id | string | ID of the administration the tax rate belongs to |
 | name | string | Name of the tax rate (e.g., "21% btw") |
 | percentage | string | Tax percentage value (e.g., "21.0") |
 | tax_rate_type | string | Type of tax rate (e.g., "sales_invoice") |
diff --git a/docs/src/content/docs/reference/time-entries.md b/docs/src/content/docs/reference/time-entries.md
@@ -95,7 +95,7 @@ When working with time entries, you'll have access to the following properties:
 | Property | Type | Description |
 |----------|------|-------------|
 | id | string | Unique identifier |
-| administration_id | int | ID of the administration the time entry belongs to |
+| administration_id | string | ID of the administration the time entry belongs to |
 | contact_id | string | ID of the contact associated with the time entry (optional) |
 | project_id | string | ID of the project associated with the time entry (optional) |
 | user_id | int | ID of the user who created the time entry |
diff --git a/docs/src/content/docs/reference/webhooks.md b/docs/src/content/docs/reference/webhooks.md
@@ -31,7 +31,7 @@ When working with webhooks, you'll have access to the following properties:
 | Property | Type | Description |
 |----------|------|-------------|
 | id | string | Unique identifier for the webhook |
-| administration_id | int | ID of the administration the webhook belongs to |
+| administration_id | string | ID of the administration the webhook belongs to |
 | url | string | URL that will receive the webhook notifications |
 | enabled_events | array | List of events the webhook is subscribed to |
 | last_http_status | int | Last HTTP status code received when delivering the webhook |
diff --git a/src/Api/Contacts/Contact.php b/src/Api/Contacts/Contact.php
@@ -8,7 +8,7 @@ class Contact extends BaseDto
 {
     public string $id;
 
-    public int $administration_id;
+    public string $administration_id;
 
     public ?string $company_name;
 
diff --git a/src/Api/ExternalSalesInvoices/ExternalSalesInvoice.php b/src/Api/ExternalSalesInvoices/ExternalSalesInvoice.php
@@ -10,7 +10,7 @@ class ExternalSalesInvoice extends BaseDto
 {
     public string $id;
 
-    public int $administration_id;
+    public string $administration_id;
 
     public string $contact_id;
 
diff --git a/src/Api/ExternalSalesInvoices/Payments/ExternalSalesInvoicePayment.php b/src/Api/ExternalSalesInvoices/Payments/ExternalSalesInvoicePayment.php
@@ -10,7 +10,7 @@ class ExternalSalesInvoicePayment extends BaseDto
 {
     public string $id;
 
-    public int $administration_id;
+    public string $administration_id;
 
     public string $invoice_type;
 
diff --git a/src/Api/SalesInvoices/SalesInvoice.php b/src/Api/SalesInvoices/SalesInvoice.php
@@ -10,7 +10,7 @@ class SalesInvoice extends BaseDto
 {
     public string $id;
 
-    public int $administration_id;
+    public string $administration_id;
 
     public string $contact_id;
 
diff --git a/src/Api/Webhooks/Webhook.php b/src/Api/Webhooks/Webhook.php
@@ -10,7 +10,7 @@ class Webhook extends BaseDto
 {
     public string $id;
 
-    public int $administration_id;
+    public string $administration_id;
 
     public string $url;
 
diff --git a/tests/Api/Contacts/ContactResponseStub.php b/tests/Api/Contacts/ContactResponseStub.php
@@ -10,7 +10,7 @@ public static function get(): array
     {
         return [
             'id' => '419889276175517682',
-            'administration_id' => 123,
+            'administration_id' => '123',
             'company_name' => 'Sandorian Consultancy B.V.',
             'firstname' => null,
             'lastname' => 'Appleseed',
diff --git a/tests/Api/ExternalSalesInvoices/ExternalSalesInvoiceResponseStub.php b/tests/Api/ExternalSalesInvoices/ExternalSalesInvoiceResponseStub.php
@@ -10,7 +10,7 @@ public static function get(): array
     {
         return [
             'id' => '426664163463398887',
-            'administration_id' => 123,
+            'administration_id' => '123',
             'contact_id' => '426664163441378788',
             'contact' => [
                 'id' => '426664163441378788',
diff --git a/tests/Api/ExternalSalesInvoices/Payments/ExternalSalesInvoicePaymentResponseStub.php b/tests/Api/ExternalSalesInvoices/Payments/ExternalSalesInvoicePaymentResponseStub.php
@@ -10,7 +10,7 @@ public static function get(): array
     {
         return [
             'id' => '426664167809746572',
-            'administration_id' => 123,
+            'administration_id' => '123',
             'invoice_type' => 'ExternalSalesInvoice',
             'invoice_id' => '426664167757317770',
             'financial_account_id' => null,
diff --git a/tests/Api/SalesInvoices/SalesInvoiceResponseStub.php b/tests/Api/SalesInvoices/SalesInvoiceResponseStub.php
@@ -10,7 +10,7 @@ public static function get(): array
     {
         return [
             'id' => '446241800938587778',
-            'administration_id' => 123,
+            'administration_id' => '123',
             'contact_id' => '446241800633452147',
             'contact' => [
                 'id' => '446241800633452147',
diff --git a/tests/Api/Webhooks/WebhooksEndpointTest.php b/tests/Api/Webhooks/WebhooksEndpointTest.php
@@ -16,7 +16,7 @@ public function test_create_webhook(): void
         $moneybird = $this->getMoneybirdClientWithMocks([
             CreateWebhookRequest::class => MockResponse::make([
                 'id' => '426664308573734088',
-                'administration_id' => 123,
+                'administration_id' => '123',
                 'url' => 'http://www.mocky.io/v2/5185415ba171ea3a00704eed',
                 'events' => [],
                 'last_http_status' => null,

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ class Contact extends BaseDto`
`8`	`8`	`{`
`9`	`9`	`public string $id;`
`10`	`10`
`11`		`- public int $administration_id;`
	`11`	`+ public string $administration_id;`
`12`	`12`
`13`	`13`	`public ?string $company_name;`
`14`	`14`