Skip to content

Commit e157c93

Browse files
committed
Updated release notes for 0.1.6
1 parent 9604eb0 commit e157c93

File tree

2 files changed

+18
-20
lines changed

2 files changed

+18
-20
lines changed

tone/Metadata/Formats/FfmetadataFormat.cs

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ public class FfmetadataFormat : IMetadataFormat
2424

2525
private const string FfmetadataHeader = ";FFMETADATA";
2626
private static readonly char[] CharsToEscape = { '=', ';', '#', '\\', '\n' };
27+
/*
2728
// TBPM=0,
2829
// TMED=CD,
2930
// language=eng,
@@ -35,7 +36,7 @@ public class FfmetadataFormat : IMetadataFormat
3536
// lyrics-XXX (where XXX is either XXX or language code, e.g. -eng)
3637
// disc
3738
//
38-
39+
*/
3940
/*
4041
const AVMetadataConv ff_id3v2_34_metadata_conv[] = {
4142
@@ -52,7 +53,8 @@ public class FfmetadataFormat : IMetadataFormat
5253
{ "USLT", "lyrics" },
5354
{ 0 }
5455
};
55-
56+
*/
57+
/*
5658
const AVMetadataConv ff_id3v2_4_metadata_conv[] = {
5759
{ "TCMP", "compilation" },
5860
{ "TDRC", "date" },
@@ -64,7 +66,8 @@ public class FfmetadataFormat : IMetadataFormat
6466
{ "TIT1", "grouping" },
6567
{ 0 }
6668
};
67-
69+
*/
70+
/*
6871
static const AVMetadataConv id3v2_2_metadata_conv[] = {
6972
7073
{ "TCP", "compilation" },
@@ -183,7 +186,7 @@ public class FfmetadataFormat : IMetadataFormat
183186
// (MetadataProperty.Conductor, typeof(string), "",null),
184187
(MetadataProperty.Copyright, typeof(string), "copyright",null),
185188
(MetadataProperty.Description, typeof(string), "description",null),
186-
// (MetadataProperty.DiscNumber, typeof(string), "album",null), // disc = 1/1
189+
// (MetadataProperty.DiscNumber, typeof(int), "disc",null), // disc = 1/1
187190
// (MetadataProperty.DiscTotal, typeof(string), "album",null), // disc = 1/1
188191
(MetadataProperty.EncodedBy, typeof(string), "encoded_by",null),
189192
// (MetadataProperty.EncoderSettings, typeof(string), "album",null),
@@ -273,6 +276,13 @@ private static void ParseMetadataProperties(Dictionary<string, string> propertie
273276
orderedKeys.Add(ffmetakey);
274277
foreach (var propertyKey in orderedKeys.Where(properties.ContainsKey))
275278
{
279+
280+
/*
281+
if (propertyKey == "disk")
282+
{
283+
284+
}
285+
*/
276286
metadata.SetMetadataPropertyValue(property, properties[propertyKey], type);
277287
}
278288
}

tone/doc/release/release-notes-v0.1.6.md

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,17 @@
11
# Release Notes
22

3-
## todo
4-
- Finish Id-Tagger + docs (for tagging via remotes with id, e.g. musicbrainz, ASIN, etc.)
5-
- AudibleIdTagger
6-
-
7-
- Try to use "year only" on date properties: https://github.com/sandreas/tone/issues/45
8-
- Fix missing metadata specs #46: https://github.com/sandreas/DotnetLibAudioMetadata/blob/0feeda2978cff3d84abd0644c1ae3ccf185d63df/Sandreas.AudioMetadata/AudioMetadata/MetadataTrack.cs#L263
9-
10-
# later
11-
- More ffmetadata support (https://github.com/sandreas/tone/issues/39)
12-
13-
143
## Fixed
154

165
- tone falsely reported as malware (#41)
176
- movement tag is not removed (#44)
187

19-
20-
218
## Changed
22-
- Upgrated `atldotnet` library
23-
- Upgrated `Jint` library (https://github.com/sandreas/tone/issues/40)
9+
- Upgrated `atldotnet` library (#58, #59)
10+
- Upgrated `Jint` library (#40)
11+
- Improved `ffmetadata` support (#39)
2412

2513
## Added
26-
14+
- Prepared code making it possible to use `--id` for simpler id based taggers (e.g. musicbrainz id)
2715
- `--export` option for `dump` command - allows you to export metadata in file (can be used together with `--format`, defaults to `json`)
2816

2917

0 commit comments

Comments
 (0)