Skip to content

Commit 3d2f40d

Browse files
authored
Merge pull request #1038 from sanger/Y25-298-mongo-8-support
Y25-298 - Mongo 8.0 support
2 parents 85024e4 + 1eb54ba commit 3d2f40d

File tree

8 files changed

+23
-21
lines changed

8 files changed

+23
-21
lines changed

.github/workflows/automated_release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ jobs:
4141
--tag docker.pkg.github.com/${IMAGE_NAME}:${BRANCH_NAME}
4242
4343
- name: Start MongoDB
44-
uses: supercharge/mongodb-github-action@1.7.0
44+
uses: supercharge/mongodb-github-action@1.12.0
4545
with:
46-
mongodb-version: 4.2
46+
mongodb-version: 8.0
4747
mongodb-replica-set: heron_rs
4848

4949
- name: Create SQL Server testing database

.github/workflows/ci.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -135,20 +135,19 @@ jobs:
135135
run: |
136136
pipenv sync --dev --system
137137
- name: Start MongoDB
138-
uses: supercharge/mongodb-github-action@1.7.0
138+
uses: supercharge/mongodb-github-action@1.12.0
139139
with:
140-
mongodb-version: 4.2
140+
mongodb-version: 8.0
141141
mongodb-replica-set: heron_rs
142142
- name: Setup the test MLWH and Events databases
143+
run: |
144+
python setup_test_db.py
145+
- name: Create SQL Server testing database
143146
run: |
144147
curl https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add -
145148
curl https://packages.microsoft.com/config/ubuntu/$(lsb_release -rs)/prod.list | sudo tee /etc/apt/sources.list.d/mssql-release.list
146149
sudo apt-get update
147150
sudo ACCEPT_EULA=Y apt-get install -y msodbcsql18
148-
sudo apt-get install -y unixodbc-dev
149-
python setup_test_db.py
150-
- name: Create SQL Server testing database
151-
run: |
152151
python setup_sqlserver_test_db.py
153152
- name: Test with pytest
154153
run: |

Dockerfile

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,15 @@ RUN apt-get update && \
2020
unixodbc-dev
2121

2222
# Install the Microsoft ODBC driver for SQL Server
23-
RUN curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add - && \
24-
curl https://packages.microsoft.com/config/debian/10/prod.list > /etc/apt/sources.list.d/mssql-release.list
23+
# https://learn.microsoft.com/en-us/sql/connect/odbc/linux-mac/installing-the-microsoft-odbc-driver-for-sql-server?view=sql-server-ver16&tabs=debian18-install%2Calpine17-install%2Cdebian8-install%2Credhat7-13-install%2Crhel7-offline#18
24+
# Download the package to configure the Microsoft repo
25+
RUN curl -sSL -O https://packages.microsoft.com/config/debian/$(grep VERSION_ID /etc/os-release | cut -d '"' -f 2 | cut -d '.' -f 1)/packages-microsoft-prod.deb
26+
# Install the package
27+
RUN dpkg -i packages-microsoft-prod.deb
28+
# Delete the file
29+
RUN rm packages-microsoft-prod.deb
2530
RUN apt-get update
2631
RUN ACCEPT_EULA=Y apt-get install -y msodbcsql18
27-
RUN apt-get install -y unixodbc-dev
2832

2933
# Install the package manager - pipenv
3034
RUN pip install --upgrade pip && \

dependencies/docker-compose.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
version: "3.8"
21
services:
32
# A MySQL service as close to production as currently possible
43
# To run it as a standalone container:
@@ -16,9 +15,9 @@ services:
1615

1716
# A MongoDB service as close to production as currently possible
1817
# To run it as a standalone container:
19-
# docker run --name mongo -d -p 27017:27017 --entrypoint="/usr/bin/mongod --bind_ip_all --replSet heron_rs" mongo:4.2
20-
mongo-4.2:
21-
image: mongo:4.2
18+
# docker run --name mongo -d -p 27017:27017 --entrypoint="/usr/bin/mongod --bind_ip_all --replSet heron_rs" mongo:8.0
19+
mongo-8.0:
20+
image: mongo:8.0
2221
container_name: mongo
2322
ports:
2423
- "27017:27017"
@@ -62,9 +61,9 @@ services:
6261
# docker network create redpanda-network
6362
# docker volume create redpanda-volume
6463
# docker run --name=schema_registry --net=redpanda-network -v "redpanda-volume:/var/lib/redpanda/data" -p 8081:8081 \
65-
# docker.vectorized.io/vectorized/redpanda start --overprovisioned --smp 1 --memory 250M
64+
# redpandadata/redpanda start --overprovisioned --smp 1 --memory 250M
6665
schema_registry:
67-
image: docker.vectorized.io/vectorized/redpanda
66+
image: redpandadata/redpanda
6867
networks:
6968
- redpanda-network
7069
ports:

dependencies/scripts/mongo-init-replica-set.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/bin/bash
22

3-
mongo <<EOF
3+
mongosh <<EOF
44
var config = {
55
_id: "heron_rs",
66
members: [{ _id: 0, host: "mongo:27017"}]

dependencies/up.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ docker compose up -d
66
# Initialise the MongoDB replica set after 5 seconds
77
sleep 5
88
printf "\n\nInitialising the MongoDB replica set...\n\n"
9-
docker exec mongo /scripts/rs-init.sh
9+
docker exec mongo /bin/bash /scripts/rs-init.sh

tests/fixtures/data/positive_samples_in_source_plate.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
)
1717
from tests.fixtures.data.source_plates import SOURCE_PLATES
1818

19-
DATE_TESTED_NOW = datetime.utcnow()
19+
DATE_TESTED_NOW = datetime.now()
2020

2121
POSITIVE_SAMPLES = [
2222
{

tests/fixtures/data/samples.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
)
1818
from tests.fixtures.data.source_plates import SOURCE_PLATES
1919

20-
DATE_TESTED_NOW = datetime.utcnow()
20+
DATE_TESTED_NOW = datetime.now()
2121
# NOTE: Remember that the samples of 'plate_123' are joined to the priority samples
2222
# There should be 7 fit to pick samples from all the plates below
2323
SAMPLES = [

0 commit comments

Comments
 (0)