feat: support FormatTime and TimeFormat.

Author: atombender

dump.go

@@ -11,6 +11,7 @@ import (
 	"sort"
 	"strconv"
 	"strings"
+	"time"
 )
 
 var (
@@ -40,6 +41,13 @@ type Options struct {
 	// when it's safe. This is useful for diffing two structures, where pointer variables would cause
 	// false changes. However, circular graphs are still detected and elided to avoid infinite output.
 	DisablePointerReplacement bool
+
+	// FormatTime, if true, will format [time.Time] values using the TimeFormat string.
+	FormatTime bool
+
+	// TimeFormat is the format string used to format [time.Time] values. If blank,
+	// time.Time.String() is used.
+	TimeFormat string
 }
 
 // Config is the default config used when calling Dump
@@ -59,6 +67,7 @@ type dumpState struct {
 	parentPointers    ptrmap
 	currentPointer    *ptrinfo
 	homePackageRegexp *regexp.Regexp
+	timeFormatter     func(t time.Time) string
 }
 
 func (s *dumpState) write(b []byte) {
@@ -129,6 +138,14 @@ func (s *dumpState) dumpSlice(v reflect.Value) {
 }
 
 func (s *dumpState) dumpStruct(v reflect.Value) {
+	val := v.Interface()
+	if t, ok := val.(time.Time); ok && s.timeFormatter != nil {
+		s.writeString("time.Time{ /* ")
+		s.writeString(s.timeFormatter(t))
+		s.writeString(" */ }")
+		return
+	}
+
 	dumpPreamble := func() {
 		s.dumpType(v)
 		s.write([]byte("{"))
@@ -246,7 +263,6 @@ func (s *dumpState) dumpChan(v reflect.Value) {
 }
 
 func (s *dumpState) dumpCustom(v reflect.Value, buf *bytes.Buffer) {
-
 	// Dump the type
 	s.dumpType(v)
 
@@ -293,6 +309,8 @@ func (s *dumpState) dump(value interface{}) {
 	s.dumpVal(v)
 }
 
+var dumperType = reflect.TypeOf((*Dumper)(nil)).Elem()
+
 func (s *dumpState) descendIntoPossiblePointer(value reflect.Value, f func()) {
 	canonicalize := true
 	if isPointerValue(value) {
@@ -345,7 +363,6 @@ func (s *dumpState) dumpVal(value reflect.Value) {
 	}
 
 	// Handle custom dumpers
-	dumperType := reflect.TypeOf((*Dumper)(nil)).Elem()
 	if v.Type().Implements(dumperType) {
 		s.descendIntoPossiblePointer(v, func() {
 			// Run the custom dumper buffering the output
@@ -464,6 +481,18 @@ func newDumpState(value reflect.Value, options *Options, writer io.Writer) *dump
 		w:        writer,
 	}
 
+	if options.FormatTime {
+		if options.TimeFormat != "" {
+			result.timeFormatter = func(t time.Time) string {
+				return t.Format(options.TimeFormat)
+			}
+		} else {
+			result.timeFormatter = func(t time.Time) string {
+				return t.String()
+			}
+		}
+	}
+
 	if options.HomePackage != "" {
 		result.homePackageRegexp = regexp.MustCompile(fmt.Sprintf("\\b%s\\.", options.HomePackage))
 	}

dump_test.go

@@ -8,6 +8,7 @@ import (
 	"os/exec"
 	"reflect"
 	"testing"
+	"time"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -163,6 +164,7 @@ func TestSdump_config(t *testing.T) {
 		(func(v IntAlias) *IntAlias { return &v })(20),
 		litter.Dump,
 		func(s string, i int) (bool, error) { return false, nil },
+		time.Date(2018, 1, 1, 0, 0, 0, 0, time.UTC),
 	}
 
 	runTestWithCfg(t, "config_Compact", &litter.Options{
@@ -204,6 +206,13 @@ func TestSdump_config(t *testing.T) {
 			return false
 		},
 	}, data)
+	runTestWithCfg(t, "config_FormatTime", &litter.Options{
+		FormatTime: true,
+	}, data)
+	runTestWithCfg(t, "config_FormatTimeWithTimeFormat", &litter.Options{
+		FormatTime: true,
+		TimeFormat: time.ANSIC,
+	}, data)
 
 	basic := &BasicStruct{1, 2}
 	runTestWithCfg(t, "config_DisablePointerReplacement_simpleReusedStruct", &litter.Options{

testdata/config_Compact.dump

@@ -1 +1 @@
-[]interface{}{litter_test.options{Compact:false,StripPackageNames:false,HidePrivateFields:true,HomePackage:"",Separator:" ",StrictGo:false},&litter_test.BasicStruct{Public:1,private:2},litter_test.Function,&20,&20,litter.Dump,func(string,int)(bool,error)}
+[]interface{}{litter_test.options{Compact:false,StripPackageNames:false,HidePrivateFields:true,HomePackage:"",Separator:" ",StrictGo:false},&litter_test.BasicStruct{Public:1,private:2},litter_test.Function,&20,&20,litter.Dump,func(string,int)(bool,error),time.Time{wall:0,ext:63650361600,loc:nil}}

testdata/config_DumpFunc.dump

@@ -16,4 +16,9 @@
   &20,
   litter.Dump,
   func(string, int) (bool, error),
+  time.Time{
+    wall: 0,
+    ext: 63650361600,
+    loc: nil,
+  },
 }

testdata/config_FieldFilter.dump

@@ -9,4 +9,5 @@
   &20,
   litter.Dump,
   func(string, int) (bool, error),
+  time.Time{},
 }

testdata/config_FormatTime.dump

@@ -0,0 +1,20 @@
+[]interface {}{
+  litter_test.options{
+    Compact: false,
+    StripPackageNames: false,
+    HidePrivateFields: true,
+    HomePackage: "",
+    Separator: " ",
+    StrictGo: false,
+  },
+  &litter_test.BasicStruct{
+    Public: 1,
+    private: 2,
+  },
+  litter_test.Function,
+  &20,
+  &20,
+  litter.Dump,
+  func(string, int) (bool, error),
+  time.Time{ /* 2018-01-01 00:00:00 +0000 UTC */ },
+}

testdata/config_FormatTimeWithTimeFormat.dump

@@ -0,0 +1,20 @@
+[]interface {}{
+  litter_test.options{
+    Compact: false,
+    StripPackageNames: false,
+    HidePrivateFields: true,
+    HomePackage: "",
+    Separator: " ",
+    StrictGo: false,
+  },
+  &litter_test.BasicStruct{
+    Public: 1,
+    private: 2,
+  },
+  litter_test.Function,
+  &20,
+  &20,
+  litter.Dump,
+  func(string, int) (bool, error),
+  time.Time{ /* Mon Jan  1 00:00:00 2018 */ },
+}

testdata/config_HidePrivateFields.dump

@@ -15,4 +15,5 @@
   &20,
   litter.Dump,
   func(string, int) (bool, error),
+  time.Time{},
 }

testdata/config_HideZeroValues.dump

@@ -12,4 +12,8 @@
   &20,
   litter.Dump,
   func(string, int) (bool, error),
+  time.Time{
+    wall: 0,
+    ext: 63650361600,
+  },
 }

testdata/config_HomePackage.dump

@@ -16,4 +16,9 @@
   &20,
   litter.Dump,
   func(string, int) (bool, error),
+  time.Time{
+    wall: 0,
+    ext: 63650361600,
+    loc: nil,
+  },
 }