'groq' cannot be used as a value because it was exported using 'export type'.

[maxence-lefebvre]

Describe the bug

Regression on groq@5.8.1/node_modules/groq/lib/groq.d.cts.

Typecheck (with tsc and tsgo) fails on

await client.fetch(groq`*[...]`, params);

with

src/example.ts - error TS1362: 'groq' cannot be used as a value because it was exported using 'export type'.

           groq`*[...]`
           ~~~~

node_modules/.pnpm/groq@5.8.1/node_modules/groq/lib/groq.d.cts:26:10 - 'groq' was exported here.
    26 export { type groq as default, type defineQuery };

To Reproduce

Steps to reproduce the behavior:

1. install groq@^5.8.1 @typescript/native-preview
2. create a file with content

import groq from "groq";

const query = groq`*[]`;

3. Run pnpm tsgo --noEmit
4. See error

Expected behavior

groq.d.cts should export the values and not the types, as does groq.d.ts and groq.cjs.

Which versions of Node.js / npm are you running?

node -v && pnpm -v
v22.22.0
10.28.2

[bjoerge]

Hi @maxence-lefebvre – Do you have "module": "commonjs" in your tsconfig by any chance? If so, could you try changing it to es2020 (or similar) and see if that works?

[maxence-lefebvre]

@bjoerge hello 👋

we are extending this one: @tsconfig/node22

    "module": "nodenext",
    "moduleResolution": "node16"
    "target": "es2022",

the typescript error indeed goes away if I override this base config with

    "module": "es2020",
    "moduleResolution": "bundler",

I mentionned in the base issue that I could see that groq.d.ts was exporting correctly the type, and that groq.cjs was indeed exporting values

/// groq.cjs
"use strict";
function defineQuery(query) {
  return query;
}
function groq(strings, ...keys) {
  const lastIndex = strings.length - 1;
  return strings.slice(0, lastIndex).reduce((acc, str, i) => acc + str + keys[i], "") + strings[lastIndex];
}
module.exports = groq;
Object.assign(module.exports, { defineQuery });
//# sourceMappingURL=groq.cjs.map

[bjoerge]

Thanks for the context, @maxence-lefebvre - much appreciated. As long as we officially support CommonJS, I think this is something we should fix. As you point out, it’s a regression and used to work.

That said, CommonJS is on its way out, and we now only support Node versions with proper ESM support and we’ll likely drop CommonJS support entirely in the near future so you might want to get ready for that future by updating your tsconfig.

[maxence-lefebvre]

We already use a bunch of ESM only modules (top of mind: sindresorhus/p-map) without issues :)

It only affected our typecheck task and it's nothing that I couldn't quickly workaround with a pnpm patch! However I'd rather not override too much a popular tsconfig/base

[bjoerge]

Hopefully #12277 fixes it. It will be out in a couple of days, but if you'd like to verify you can try with sanity@next

[maxence-lefebvre]

@bjoerge

it looks like it doesn't: https://npmx.dev/package-code/groq/v/5.13.0-next.28/lib%2Fgroq.d.cts

[bjoerge]

Can you check with 5.13.0? We've removed the groq.d.cts entirely, package types should use groq.d.ts now.

[maxence-lefebvre]

good morning, I did my morning housekeeping and indeed, groq@5.13.0 solved the issue!

thank you very much!

(closing it for you)

[bjoerge]

Happy to hear, thank you for confirming!