Skip to content

Commit fe682b9

Browse files
authored
Merge pull request #6 from sanity-labs/default-visual-center-y
feat: default alignBy to visual-center-y
2 parents 309f731 + ace6bdd commit fe682b9

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ Imagine you have two logos:
9797

9898
### `alignBy`
9999

100-
How to align logos. Default is `"bounds"`.
100+
How to align logos. Default is `"visual-center-y"`.
101101

102102
- `"bounds"` — Align by geometric center (bounding box)
103103
- `"visual-center"` — Align by visual weight center (accounts for asymmetric logos)

src/constants.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
import type { AlignmentMode } from "./types";
22

3-
export const DEFAULT_ALIGN_BY: AlignmentMode = "bounds";
3+
export const DEFAULT_ALIGN_BY: AlignmentMode = "visual-center-y";
44
export const DEFAULT_GAP = 28;
55
export const DEFAULT_BASE_SIZE = 48;
66
export const DEFAULT_SCALE_FACTOR = 0.5;
77
export const DEFAULT_CONTRAST_THRESHOLD = 10;
8+
export const DEFAULT_DENSITY_AWARE = true;
89
export const DEFAULT_DENSITY_FACTOR = 0.5;
10+
export const DEFAULT_CROP_TO_CONTENT = false;

src/hooks/useLogoSoup.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ import { useEffect, useReducer, useRef } from "react";
22
import {
33
DEFAULT_BASE_SIZE,
44
DEFAULT_CONTRAST_THRESHOLD,
5+
DEFAULT_CROP_TO_CONTENT,
6+
DEFAULT_DENSITY_AWARE,
57
DEFAULT_DENSITY_FACTOR,
68
DEFAULT_SCALE_FACTOR,
79
} from "../constants";
@@ -63,9 +65,9 @@ export function useLogoSoup(options: UseLogoSoupOptions): UseLogoSoupResult {
6365
baseSize = DEFAULT_BASE_SIZE,
6466
scaleFactor = DEFAULT_SCALE_FACTOR,
6567
contrastThreshold = DEFAULT_CONTRAST_THRESHOLD,
66-
densityAware = true,
68+
densityAware = DEFAULT_DENSITY_AWARE,
6769
densityFactor = DEFAULT_DENSITY_FACTOR,
68-
cropToContent = false,
70+
cropToContent = DEFAULT_CROP_TO_CONTENT,
6971
} = options;
7072

7173
const [state, dispatch] = useReducer(reducer, INITIAL_STATE);

stories/LogoSoup.stories.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ import { useMemo } from "react";
44
import {
55
DEFAULT_ALIGN_BY,
66
DEFAULT_BASE_SIZE,
7+
DEFAULT_CROP_TO_CONTENT,
8+
DEFAULT_DENSITY_AWARE,
79
DEFAULT_DENSITY_FACTOR,
810
DEFAULT_GAP,
911
DEFAULT_SCALE_FACTOR,
@@ -275,9 +277,9 @@ export const Playground: Story = {
275277
shuffleSeed: 42,
276278
baseSize: DEFAULT_BASE_SIZE,
277279
scaleFactor: DEFAULT_SCALE_FACTOR,
278-
densityAware: true,
280+
densityAware: DEFAULT_DENSITY_AWARE,
279281
densityFactor: DEFAULT_DENSITY_FACTOR,
280-
cropToContent: false,
282+
cropToContent: DEFAULT_CROP_TO_CONTENT,
281283
alignBy: DEFAULT_ALIGN_BY,
282284
gap: DEFAULT_GAP,
283285
showImageBounds: false,

0 commit comments

Comments
 (0)