[Client] Fix: send json data as json

Author: santiher

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to this project will be documented here.
 
+## [0.2.2] - 2019-07-12
+### Fixed
+- Send json data actually as json.
+
 ## [0.2.1] - 2019-07-08
 ### Fixed
 - Object creation when requesting a single object.

helpscout/__init__.py

@@ -1,4 +1,4 @@
 from helpscout.client import HelpScout  # noqa
 
 
-__version__ = '0.2.1'
+__version__ = '0.2.2'

helpscout/client.py

@@ -137,7 +137,7 @@ def hit(self, endpoint, method, resource_id=None, data=None, params=None):
                 params = '&'.join('%s=%s' % (k, v) for k, v in params.items())
             url = '%s?%s' % (url, params)
         headers = self._authentication_headers()
-        r = getattr(requests, method)(url, headers=headers, data=data)
+        r = getattr(requests, method)(url, headers=headers, json=data)
         logger.debug('%s %s' % (method, url))
         ok, status_code = r.ok, r.status_code
         if status_code in (201, 204):

tests/helpscout/test_client.py

@@ -103,7 +103,7 @@ def test_hit_no_access_token_ok(self):
             auth_headers.assert_called_once()
             logger.debug.assert_called_once_with(method + ' ' + full_url)
             requests.get.assert_called_once_with(
-                full_url, headers=headers, data=None)
+                full_url, headers=headers, json=None)
             response.json.assert_called_once()
             pages.assert_called_once_with(json_response, method)
 
@@ -128,7 +128,7 @@ def test_hit_ok(self):
             auth_headers.assert_called_once()
             logger.debug.assert_called_once_with(method + ' ' + full_url)
             requests.get.assert_called_once_with(
-                full_url, headers=headers, data=None)
+                full_url, headers=headers, json=None)
             response.json.assert_called_once()
             pages.assert_called_once_with(json_response, method)
 
@@ -153,7 +153,7 @@ def test_hit_resource_id_ok(self):
             auth_headers.assert_called_once()
             logger.debug.assert_called_once_with(method + ' ' + full_url)
             requests.get.assert_called_once_with(
-                full_url, headers=headers, data=None)
+                full_url, headers=headers, json=None)
             response.json.assert_called_once()
             pages.assert_called_once_with(json_response, method)
 
@@ -179,7 +179,7 @@ def test_hit_params_dict_ok(self):
             auth_headers.assert_called_once()
             logger.debug.assert_called_once_with(method + ' ' + full_url)
             requests.get.assert_called_once_with(
-                full_url, headers=headers, data=None)
+                full_url, headers=headers, json=None)
             response.json.assert_called_once()
             pages.assert_called_once_with(json_response, method)
 
@@ -205,7 +205,7 @@ def test_hit_resource_id_with_params_dict_ok(self):
             auth_headers.assert_called_once()
             logger.debug.assert_called_once_with(method + ' ' + full_url)
             requests.get.assert_called_once_with(
-                full_url, headers=headers, data=None)
+                full_url, headers=headers, json=None)
             response.json.assert_called_once()
             pages.assert_called_once_with(json_response, method)
 
@@ -232,7 +232,7 @@ def test_hit_resource_id_with_params_str_ok(self):
             auth_headers.assert_called_once()
             logger.debug.assert_called_once_with(method + ' ' + full_url)
             requests.get.assert_called_once_with(
-                full_url, headers=headers, data=None)
+                full_url, headers=headers, json=None)
             response.json.assert_called_once()
             pages.assert_called_once_with(json_response, method)
 
@@ -258,7 +258,7 @@ def test_hit_post_ok(self):
             auth_headers.assert_called_once()
             logger.debug.assert_called_once_with(method + ' ' + full_url)
             requests.post.assert_called_once_with(
-                full_url, headers=headers, data=None)
+                full_url, headers=headers, json=None)
             response.json.assert_not_called()
             pages.assert_not_called()
             self.assertEqual(ret, [None])
@@ -285,7 +285,7 @@ def test_hit_delete_ok(self):
             auth_headers.assert_called_once()
             logger.debug.assert_called_once_with(method + ' ' + full_url)
             requests.delete.assert_called_once_with(
-                full_url, headers=headers, data=None)
+                full_url, headers=headers, json=None)
             response.json.assert_not_called()
             pages.assert_not_called()
             self.assertEqual(ret, [None])
@@ -312,7 +312,7 @@ def test_hit_patch_ok(self):
             auth_headers.assert_called_once()
             logger.debug.assert_called_once_with(method + ' ' + full_url)
             requests.patch.assert_called_once_with(
-                full_url, headers=headers, data=None)
+                full_url, headers=headers, json=None)
             response.json.assert_not_called()
             pages.assert_not_called()
             self.assertEqual(ret, [None])
@@ -341,7 +341,7 @@ def test_hit_token_expired(self):
                 [call(method + ' ' + full_url) for _ in range(2)])
             self.assertEqual(
                 requests.get.call_args_list,
-                [call(full_url, headers=headers, data=None) for _ in range(2)])
+                [call(full_url, headers=headers, json=None) for _ in range(2)])
             response.json.assert_called_once()
             pages.assert_called_once_with(json_response, method)
             auth.assert_called_once()
@@ -371,7 +371,7 @@ def test_hit_rate_limit_exceeded(self):
                 [call(method + ' ' + full_url) for _ in range(2)])
             self.assertEqual(
                 requests.get.call_args_list,
-                [call(full_url, headers=headers, data=None) for _ in range(2)])
+                [call(full_url, headers=headers, json=None) for _ in range(2)])
             response.json.assert_called_once()
             pages.assert_called_once_with(json_response, method)
             rate_limit.assert_called_once()
@@ -402,7 +402,7 @@ def test_hit_exception(self):
             auth_headers.assert_called_once()
             logger.debug.assert_called_once_with(method + ' ' + full_url)
             requests.get.assert_called_once_with(
-                full_url, headers=headers, data=None)
+                full_url, headers=headers, json=None)
             response.json.assert_not_called()
             pages.assert_not_called()
             rate_limit.assert_not_called()