[f5] change the way strict is disabled

proactivly remove strict from all childs before removing parent/child
dependency.

Also, force update of all endpoint/services with sql migration.

Author: notandy

internal/agent/f5/bigip/bigip.go

@@ -207,6 +207,18 @@ func (b *BigIP) EnsureRouteDomain(segmentId int, _ *int) error {
 		Parent: "",
 	}
 
+	// Disable all strict of Children
+	// TODO: remove code after all strict's disabled
+	for _, rd := range routeDomains.RouteDomains {
+		if rd.Strict == "enabled" && rd.Parent != "" {
+			log.WithField("route domain", rd.Name).Warning("Found route domain with strict enabled, updating to disabled")
+			rd.Strict = "disabled"
+			if err = rd.Update(b); err != nil {
+				log.WithField("route domain", rd.Name).Errorf("failed to disable strict on route domain: %v", err)
+			}
+		}
+	}
+
 	for _, rd := range routeDomains.RouteDomains {
 		if rd.ID != segmentId {
 			continue
@@ -216,15 +228,6 @@ func (b *BigIP) EnsureRouteDomain(segmentId int, _ *int) error {
 			// already exists, nothing to do
 			return nil
 		}
-
-		// Special case where strict isolation and parenting is still on
-		if rd.Parent != "" && rd.Strict == "enabled" {
-			c.Parent = rd.Parent
-			log.WithField("route domain", rd.Name).Warning("Found route domain with strict enabled, updating to disabled, retrying")
-			if err = c.Update(b); err != nil {
-				return fmt.Errorf("failed to disable strict on route domain: %w", err)
-			}
-		}
 	}
 
 	return c.Update(b)

internal/db/migrations/migration.go

@@ -290,4 +290,12 @@ var Migrations = mgx.Migrations(
 		`)
 		return err
 	}),
+	mgx.NewMigration("set_to_pending_update", func(ctx context.Context, commands mgx.Commands) error {
+		_, err := commands.Exec(ctx, `
+			-- set all services and endpoints to PENDING_UPDATE to trigger reconciliation
+			UPDATE service SET status = 'PENDING_UPDATE' WHERE status = 'AVAILABLE' AND provider = 'tenant';
+			UPDATE endpoint SET status = 'PENDING_UPDATE' WHERE status = 'AVAILABLE' AND endpoint.id IN (SELECT ep.id FROM endpoint ep JOIN service s ON ep.service_id = s.id WHERE s.provider = 'tenant');
+		`)
+		return err
+	}),
 )

internal/db/migrations/migration_test.go

@@ -10,6 +10,7 @@ import (
 
 	"github.com/jackc/pgx/v5"
 	"github.com/sapcc/go-bits/osext"
+	"github.com/testcontainers/testcontainers-go"
 	"github.com/testcontainers/testcontainers-go/modules/postgres"
 	"github.com/z0ne-dev/mgx/v2"
 )
@@ -23,6 +24,7 @@ func TestMigrate(t *testing.T) {
 	// start postgres container
 	pgContainer, err := postgres.Run(t.Context(),
 		"postgres:16-alpine",
+		testcontainers.WithProvider(testcontainers.ProviderPodman),
 		postgres.BasicWaitStrategies(),
 	)
 	if err != nil {