Skip to content

Commit 3a0241e

Browse files
authored
Merge pull request #6 from sapcc/workflow-release
git tag step removed from release workflow
2 parents 81142be + 4e1558a commit 3a0241e

File tree

2 files changed

+5
-21
lines changed

2 files changed

+5
-21
lines changed

.github/workflows/README.md

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ The project uses two main workflows that work together to ensure code quality an
5050
- Verifies version format matches `X.Y.Z` pattern (e.g., `1.2.3`)
5151
- Checks that the git tag doesn't already exist
5252
- Sets up Go using version from go.mod
53-
- Runs [golangci-lint](https://github.com/golangci/golangci-lint) v2.4.0 for static code analysis
53+
- Runs [golangci-lint](https://github.com/golangci/golangci-lint) for static code analysis
5454
- Runs [govulncheck](https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck) for vulnerability scanning
5555
- Executes unit tests with coverage reporting
5656
- Builds the `check` binary with version information
@@ -75,7 +75,7 @@ The project uses two main workflows that work together to ensure code quality an
7575

7676
#### Jobs and Steps
7777
- **createRelease:**
78-
- Checks out code
78+
- Checks out code with full history (fetch-depth: 0)
7979
- Installs [mdq](https://github.com/yshavit/mdq) tool for changelog parsing
8080
- Populates environment variables:
8181
- `BUILD_DATE` - Current UTC timestamp
@@ -104,10 +104,7 @@ The project uses two main workflows that work together to ensure code quality an
104104
- Sets `makeLatest: "legacy"` for latest release handling
105105
- Skips if release already exists
106106
- Updates only unreleased releases
107-
- Creates and pushes git tag:
108-
- Configures git user
109-
- Creates annotated tag with changelog content
110-
- Pushes tag to origin
107+
- Creates git tag automatically via the release action
111108

112109
## Environment Variables
113110

@@ -154,7 +151,6 @@ flowchart TB
154151
155152
subgraph "Github Releases & Tags"
156153
E --> PR
157-
E --> GT
158154
end
159155
160156
U --Push to feature branch--> D
@@ -165,8 +161,7 @@ flowchart TB
165161
U(Developer)
166162
CID@{ shape: div-rect, label: "Draft container image\n(draft, X.Y.Z)" }
167163
CIR@{ shape: div-rect, label: "Release container image\n(latest, release, X.Y.Z)" }
168-
PR@{ shape: lin-rect, label: "Published Release" }
169-
GT@{ shape: lin-rect, label: "Git Tag" }
164+
PR@{ shape: lin-rect, label: "Published Release\n(with Git Tag)" }
170165
```
171166

172167
## Release Process
@@ -187,8 +182,7 @@ The complete release process follows this flow:
187182
- Merge the approved changes to the `master` branch
188183
- This triggers the [Publish Release workflow](#publish-release-workflow) which:
189184
- Builds and pushes the release container image
190-
- Creates a GitHub release with the changelog
191-
- Creates and pushes a git tag for the version
185+
- Creates a GitHub release with the changelog (including a git tag)
192186

193187
## Dependencies
194188

.github/workflows/publish-release.yaml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -111,13 +111,3 @@ jobs:
111111
skipIfReleaseExists: true
112112
allowUpdates: true
113113
updateOnlyUnreleased: true
114-
- name: 'create tag'
115-
shell: 'bash'
116-
run: |
117-
#!/usr/bin/env bash
118-
set -euo pipefail
119-
120-
git config --local user.email "workflow@github.local"
121-
git config --local user.name "workflow"
122-
git tag --annotate "${GIT_TAG}" --message="$(./mdq "# \"${GIT_TAG}\"" CHANGELOG.md)"
123-
git push origin "${GIT_TAG}"

0 commit comments

Comments
 (0)