Warn when metadata.url is not a https URL and don't fallback to internal actions

Author: SuperSandro2000

internal/makefile/makefile.go

@@ -35,6 +35,12 @@ func newMakefile(cfg core.Configuration, sr golang.ScanResult) *makefile {
 	runControllerGen := cfg.ControllerGen.Enabled.UnwrapOr(sr.KubernetesController)
 	// TODO: checking on GoVersion is only an aid until we can properly detect rust applications
 	isGolang := sr.GoVersion != ""
+
+	if !strings.HasPrefix(cfg.Metadata.URL, "https://") {
+		logg.Error("The option metadata.url should always start with https://, eg: https://github.com/sapcc/go-makefile-maker")
+		logg.Error("Some defaults or usages of the metadata might not work correctly")
+	}
+
 	isSAPCC := cfg.Metadata.IsSAPProject()
 
 	///////////////////////////////////////////////////////////////////////////

main.go

@@ -51,7 +51,8 @@ func main() {
 	must.Succeed(file.Close())
 	cfg.Validate()
 
-	if cfg.GitHubWorkflow != nil && !strings.HasPrefix(cfg.Metadata.URL, "https://github.com/") {
+	// The github.com/ prefix is just a safeguard to avoid false positives when the metadata.url is not complete.
+	if cfg.GitHubWorkflow != nil && !strings.Contains(cfg.Metadata.URL, "github.com/") {
 		cfg.GitHubWorkflow.IsSelfHostedRunner = true
 		if strings.Contains(cfg.Metadata.URL, "/sap-cloud-infrastructure/") {
 			cfg.GitHubWorkflow.IsSugarRunner = true