Merge pull request #354 from sapcc/enterprise-artifact

Use older upload-artifact on GHE

Author: majewsky

internal/core/constants.go

@@ -16,10 +16,19 @@ var DefaultGitHubEnterpriseRunsOn = map[string]string{
 }
 var SugarRunsOn = []string{"self-hosted"}
 
+// GetUploadArtifactAction works around GitHub not supporting their own stuff
+// https://github.com/actions/upload-artifact/issues/537
+func GetUploadArtifactAction(isSelfHostedRunner bool) string {
+	if isSelfHostedRunner {
+		return "actions/upload-artifact@v2"
+	} else {
+		return "actions/upload-artifact@v4"
+	}
+}
+
 const (
-	CheckoutAction       = "actions/checkout@v5"
-	SetupGoAction        = "actions/setup-go@v5"
-	UploadArtifactAction = "actions/upload-artifact@v4"
+	CheckoutAction = "actions/checkout@v5"
+	SetupGoAction  = "actions/setup-go@v5"
 
 	DockerLoginAction     = "docker/login-action@v3"
 	DockerMetadataAction  = "docker/metadata-action@v5"

internal/ghworkflow/workflow_ci.go

@@ -57,7 +57,7 @@ func ciWorkflow(cfg core.Configuration, sr golang.ScanResult) {
 	coverageArtifactName := "code-coverage"
 	testJob.addStep(jobStep{
 		Name: "Archive code coverage results",
-		Uses: core.UploadArtifactAction,
+		Uses: core.GetUploadArtifactAction(ghwCfg.IsSelfHostedRunner),
 		With: map[string]any{
 			"name": coverageArtifactName,
 			"path": "build/cover.out",