Skip to content

Commit e3d7944

Browse files
Do not try to delete shellcheck on selfhosted runners
It is not installed there per default and also on SUGAR runners there is no sudo available. So much about self hosted runners being compatible.
1 parent 0e32f65 commit e3d7944

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

internal/ghworkflow/workflow_checks.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,12 @@ func checksWorkflow(cfg core.Configuration) {
2929

3030
if cfg.ShellCheck.Enabled.UnwrapOr(true) {
3131
// delete the pretty out of date installed version of shellcheck so that make install-shellcheck installs the current version
32-
j.addStep(jobStep{
33-
Name: "Delete pre-installed shellcheck",
34-
Run: "sudo rm -f $(which shellcheck)",
35-
})
32+
if !ghwCfg.IsSelfHostedRunner {
33+
j.addStep(jobStep{
34+
Name: "Delete pre-installed shellcheck",
35+
Run: "sudo rm -f $(which shellcheck)",
36+
})
37+
}
3638
j.addStep(jobStep{
3739
Name: "Run shellcheck",
3840
Run: "make run-shellcheck",

0 commit comments

Comments
 (0)