From e3d79443562fa2da91a4a69c97f77567d4813a11 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Tue, 12 Aug 2025 17:59:56 +0200 Subject: [PATCH] Do not try to delete shellcheck on selfhosted runners It is not installed there per default and also on SUGAR runners there is no sudo available. So much about self hosted runners being compatible. --- internal/ghworkflow/workflow_checks.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/internal/ghworkflow/workflow_checks.go b/internal/ghworkflow/workflow_checks.go index 36f7409c..5274674e 100644 --- a/internal/ghworkflow/workflow_checks.go +++ b/internal/ghworkflow/workflow_checks.go @@ -29,10 +29,12 @@ func checksWorkflow(cfg core.Configuration) { if cfg.ShellCheck.Enabled.UnwrapOr(true) { // delete the pretty out of date installed version of shellcheck so that make install-shellcheck installs the current version - j.addStep(jobStep{ - Name: "Delete pre-installed shellcheck", - Run: "sudo rm -f $(which shellcheck)", - }) + if !ghwCfg.IsSelfHostedRunner { + j.addStep(jobStep{ + Name: "Delete pre-installed shellcheck", + Run: "sudo rm -f $(which shellcheck)", + }) + } j.addStep(jobStep{ Name: "Run shellcheck", Run: "make run-shellcheck",