[golanci.yaml.tmpl] disable modernize omitzero plugin with controller-gen#406
Merged
[golanci.yaml.tmpl] disable modernize omitzero plugin with controller-gen#406
Conversation
notandy
requested review from
Nuckal777,
SuperSandro2000,
VoigtS,
majewsky and
wagnerd3
as code owners
majewsky
requested changes
Nov 7, 2025
notandy
force-pushed
the
disable-modernize-omitzero-plugin
branch
from
33f0e8b to
cfa6dbb
Compare
This plugin is breaking practically all kubernetes-operators that have CRDs. The CRDs are generated from golang types, where the omitempty tag for nested structs has an direct effect on the generated CRD - they just don't work without omitempty. ``` Error: api/v1/eviction_types.go:91:20: omitzero: Omitempty has no effect on nested struct fields (modernize) ```
notandy
force-pushed
the
disable-modernize-omitzero-plugin
branch
from
cfa6dbb to
5e2d618
Compare
notandy
changed the title
Contributor
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
SuperSandro2000
approved these changes
Nov 7, 2025
majewsky
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This plugin is breaking practically all kubernetes-operators that have
CRDs. The CRDs are generated from golang types, where the omitempty tag
for nested structs has an direct effect on the generated CRD - they just
don't work without omitempty.
Reference: https://github.com/cobaltcore-dev/openstack-hypervisor-operator/actions/runs/19146731726/job/54726200638