Merge pull request #366 from sapcc/fix-lints

fix new gosec lints

Author: majewsky

common/openstack.go

@@ -21,7 +21,7 @@ type OpenStackConfig struct {
 	Region     string
 	AuthURL    string
 	Username   string
-	Password   string
+	Password   string // #nosec G117 - intentional passing of secret credential
 	Domainname string
 	ProjectID  string
 }
@@ -31,7 +31,7 @@ func parseOSConfig(data []byte) (OpenStackConfig, error) {
 		Global struct {
 			AuthURL    string `ini:"auth-url"`
 			Username   string `ini:"username"`
-			Password   string `ini:"password"`
+			Password   string `ini:"password"` // #nosec G117 - intentional passing of secret credential
 			Region     string `ini:"region"`
 			Domainname string `ini:"domain-name"`
 			TenantID   string `ini:"tenant-id"`

esx/config.go

@@ -51,7 +51,7 @@ func (c *Config) AlarmsAsSet() map[string]struct{} {
 
 type Credential struct {
 	Username string `config:"username" validate:"required"`
-	Password string `config:"password"`
+	Password string `config:"password"` // #nosec G117 - intentional passing of secret credential
 }
 
 // VCenters contains connection information to regional vCenters.

plugin/impl/mail.go

@@ -22,7 +22,7 @@ type Mail struct {
 	To       []string
 	Identity string
 	User     string
-	Password string
+	Password string // #nosec G117 - intentional passing of secret credential
 }
 
 // New creates a new Mail instance with the given config.
@@ -36,7 +36,7 @@ func (m *Mail) New(config *ucfgwrap.Config) (plugin.Notifier, error) {
 		To       []string `config:"to" validate:"required"`
 		Identity string   `config:"identity"`
 		User     string   `config:"user"`
-		Password string   `config:"password"`
+		Password string   `config:"password"` // #nosec G117 - intentional passing of secret credential
 	}{}
 	if err := config.Unpack(&conf); err != nil {
 		return nil, err