Merge pull request #116 from sapcc/fix-failed-create-uri

Fix audit target URI for failed create operations

Author: notque

auditmiddleware/_api.py

@@ -499,7 +499,8 @@ def _create_event_from_payload(self, target_project, res_spec, res_id,
 
         ev.target = self._create_target_resource(target_project, res_spec,
                                                  res_id, res_parent_id,
-                                                 subpayload)
+                                                 request=request,
+                                                 payload=subpayload)
 
         # extract custom attributes from the payload
         for attr, typeURI in res_spec.custom_attributes.items():
@@ -589,10 +590,13 @@ def _create_cadf_event(self, project, res_spec, res_id, res_parent_id,
         target = None
         if res_id or res_parent_id:
             target = self._create_target_resource(project, res_spec, res_id,
-                                                  res_parent_id, key=key)
+                                                  res_parent_id,
+                                                  request=request,
+                                                  key=key)
         else:
             target = self._create_target_resource(project, res_spec,
                                                   None, self._service_id,
+                                                  request=request,
                                                   key=key)
             target.name = self._service_name
 
@@ -654,7 +658,8 @@ def _attach_payload(event, payload, res_spec):
         event.add_attachment(attach_val)
 
     def _create_target_resource(self, target_project, res_spec, res_id,
-                                res_parent_id=None, payload=None, key=None):
+                                res_parent_id=None, request=None,
+                                payload=None, key=None):
         """Build the event's target element from  the payload."""
         self._log.debug("_create_target_resource: res_spec=%(res_spec)s, "
             "res_id=%(res_id)s, res_parent_id=%(res_parent_id)s",
@@ -682,7 +687,16 @@ def _create_target_resource(self, target_project, res_spec, res_id,
                     payload,
                     res_spec)
 
-        type_uri = res_spec.el_type_uri if rid else res_spec.type_uri
+        type_uri = res_spec.type_uri
+        if rid:
+            # if we have a resource ID (from path or payload), use element URI
+            type_uri = res_spec.el_type_uri or res_spec.type_uri
+        elif request and request.method == 'POST' and not res_spec.singleton:
+            # if it's a POST to a non-singleton resource
+            # (even if failed, so no rid yet)
+            # the intent is an element, so use element URI
+            type_uri = res_spec.el_type_uri or res_spec.type_uri
+
         rid = _make_uuid(rid or res_parent_id or taxonomy.UNKNOWN)
         target = OpenStackResource(project_id=project_id, id=rid,
                                    typeURI=type_uri, name=name)

test-requirements.txt

@@ -11,7 +11,7 @@ coverage!=4.4,>=4.0 # Apache-2.0
 fixtures>=3.0.0 # Apache-2.0/BSD
 mock>=3.0.0 # BSD
 oslotest>=3.8.0 # Apache-2.0
-pytz==2025.1 # MIT
+pytz>=2025.2 # MIT
 requests-mock>=1.2.0 # Apache-2.0
 #stevedore>=1.20.0 # Apache-2.0
 stestr>=2.0.0  # Apache-2.0