refactor: improve code quality by addressing SonarQube code smells (#336)

* refactor: improve code quality by addressing SonarQube code smells

This commit addresses 7 code smell issues identified by SonarQube:

- src/domains/base.ts:48: Use String#replaceAll() instead of replace()
- src/domains/system.ts:46: Use for...of instead of forEach() for better performance
- src/utils/pattern-matcher.ts:35-37: Use String#replaceAll() and String.raw for cleaner code

Changes:
- Replaced regex-based replace() calls with replaceAll() for better readability
- Converted forEach() to for...of loop for improved performance
- Used String.raw template literal to avoid unnecessary escaping

All tests passing (1012/1012). Technical debt reduced by 30 minutes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

* chore: add changeset for code quality improvements

* fix: use string literals instead of regex for simple character replacements

SonarCloud flagged that replaceAll() with simple character patterns
should use string literals instead of regex for better performance
and readability.

Changes:
- src/utils/pattern-matcher.ts:36: Changed /\*/g to '*'
- src/utils/pattern-matcher.ts:37: Changed /\?/g to '?'

This resolves 2 new code smells introduced in the previous commit
and should improve the SonarCloud quality gate status.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

* refactor: use conventional string escaping instead of String.raw

Addressed Copilot review feedback. While both String.raw and conventional
escaping produce identical results, using '\$&' is more conventional and
clearer for replacement patterns in replaceAll().

This improves code maintainability without changing functionality.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

---------

Co-authored-by: Claude <[email protected]>

Author: sapientpants

.changeset/code-quality-improvements.md

@@ -0,0 +1,13 @@
+---
+'sonarqube-mcp-server': patch
+---
+
+refactor: improve code quality by addressing SonarQube code smells
+
+Improved code readability and maintainability by addressing 7 code smell issues:
+
+- Use `String#replaceAll()` instead of `replace()` with global regex for better clarity
+- Convert `forEach()` to `for...of` loop for improved performance and readability
+- Use `String.raw` template literal to avoid unnecessary escaping in regex patterns
+
+These changes follow modern JavaScript/TypeScript best practices and reduce technical debt by 30 minutes. No functional changes or breaking changes introduced.

src/domains/base.ts

@@ -45,7 +45,7 @@ export abstract class BaseDomain {
       });
 
     // Wrap operation with circuit breaker
-    const breakerName = `sonarqube.${endpoint.replace(/\//g, '.')}`;
+    const breakerName = `sonarqube.${endpoint.replaceAll('/', '.')}`;
     const wrappedOperation = wrapWithCircuitBreaker(breakerName, retryableOperation, {
       timeout: 30000, // 30 seconds
       errorThresholdPercentage: 50,

src/domains/system.ts

@@ -43,11 +43,11 @@ export class SystemDomain extends BaseDomain {
     }
 
     const causes: string[] = [];
-    nodes.forEach((node) => {
+    for (const node of nodes) {
       if (node.causes) {
         causes.push(...node.causes);
       }
-    });
+    }
 
     return causes;
   }

src/utils/pattern-matcher.ts

@@ -32,9 +32,9 @@ export class PatternMatcher {
   private globToRegex(pattern: string): RegExp {
     // Escape all regex special characters except * and ?
     const escaped = pattern
-      .replace(/[\\^$.()|[\]{}+]/g, '\\$&') // Escape regex special chars
-      .replace(/\*/g, '.*') // * matches any sequence
-      .replace(/\?/g, '.'); // ? matches any single character
+      .replaceAll(/[\\^$.()|[\]{}+]/g, '\\$&') // Escape regex special chars
+      .replaceAll('*', '.*') // * matches any sequence
+      .replaceAll('?', '.'); // ? matches any single character
 
     // Create regex with anchors for full string matching
     return new RegExp(`^${escaped}$`);