[libclc][Native CPU] Add missing _CLC_DEF. (intel#19367)

hvdijk · web-flow · commit 877f4207ecd8 · 2025-07-09T15:24:19.000-07:00
libclc functions are meant to be declared with _CLC_DECL and defined
with _CLC_DEF. A few Native CPU functions were defined without _CLC_DEF,
so add the missing macro.

This is effectively NFC, this applied to trivial functions that were
being defined without always_inline but that would be inlined anyway.
diff --git a/libclc/libspirv/lib/native_cpu/math/helpers.h b/libclc/libspirv/lib/native_cpu/math/helpers.h
@@ -15,12 +15,12 @@
 // __builtin_elementwise_##NAME
 #ifndef IS_FABS
 #define GEN_UNARY_VECTOR_BUILTIN(NAME, TYPE, NUM)                              \
-  _CLC_OVERLOAD TYPE##NUM GETNAME(NAME)(TYPE##NUM n) {                         \
+  _CLC_DEF _CLC_OVERLOAD TYPE##NUM GETNAME(NAME)(TYPE##NUM n) {                \
     return __builtin_elementwise_##NAME(n);                                    \
   }
 #else
 #define GEN_UNARY_VECTOR_BUILTIN(NAME, TYPE, NUM)                              \
-  _CLC_OVERLOAD TYPE##NUM GETNAME(NAME)(TYPE##NUM n) {                         \
+  _CLC_DEF _CLC_OVERLOAD TYPE##NUM GETNAME(NAME)(TYPE##NUM n) {                \
     return __builtin_elementwise_abs(n);                                       \
   }
 #endif
@@ -33,7 +33,9 @@
   GEN_UNARY_VECTOR_BUILTIN(NAME, TYPE, 16)
 
 #define GEN_UNARY_BUILTIN_T(NAME, TYPE)                                        \
-  _CLC_OVERLOAD TYPE GETNAME(NAME)(TYPE n) { return __builtin_##NAME(n); }
+  _CLC_DEF _CLC_OVERLOAD TYPE GETNAME(NAME)(TYPE n) {                          \
+    return __builtin_##NAME(n);                                                \
+  }
 
 #if defined(cl_khr_fp16)
 #define GEN_UNARY_FP16(NAME)                                                   \
@@ -58,8 +60,8 @@
   GEN_UNARY_FP64(NAME)
 
 #define GEN_TERNARY_VECTOR_BUILTIN(NAME, TYPE, NUM)                            \
-  _CLC_OVERLOAD TYPE##NUM GETNAME(NAME)(TYPE##NUM n1, TYPE##NUM n2,            \
-                                        TYPE##NUM n3) {                        \
+  _CLC_DEF _CLC_OVERLOAD TYPE##NUM GETNAME(NAME)(TYPE##NUM n1, TYPE##NUM n2,   \
+                                                 TYPE##NUM n3) {               \
     return __builtin_elementwise_##NAME(n1, n2, n3);                           \
   }
 
@@ -71,7 +73,7 @@
   GEN_TERNARY_VECTOR_BUILTIN(NAME, TYPE, 16)
 
 #define GEN_TERNARY_BUILTIN_T(NAME, TYPE)                                      \
-  _CLC_OVERLOAD TYPE GETNAME(NAME)(TYPE n1, TYPE n2, TYPE n3) {                \
+  _CLC_DEF _CLC_OVERLOAD TYPE GETNAME(NAME)(TYPE n1, TYPE n2, TYPE n3) {       \
     return __builtin_##NAME(n1, n2, n3);                                       \
   }
 
