Skip to content

Commit 1e1c590

Browse files
committed
use deep merge in unstuctured join
1 parent 9cdb8e6 commit 1e1c590

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

SpiffWorkflow/bpmn/specs/mixins/unstructured_join.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
# 02110-1301 USA
1919
from copy import deepcopy
2020

21+
from SpiffWorkflow.util.deep_merge import DeepMerge
2122
from SpiffWorkflow.util.task import TaskState, TaskIterator
2223
from SpiffWorkflow.specs.Join import Join
2324

@@ -50,7 +51,7 @@ def _run_hook(self, my_task):
5051
for task in sorted(other_tasks, key=lambda t: t.last_state_change):
5152
# By inheriting directly from parent tasks, we can avoid copying previouly merged data
5253

53-
my_task.set_data(**deepcopy(task.parent.data))
54+
DeepMerge.merge(my_task.data, task.parent.data)
5455
# This condition only applies when a workflow is reset inside a parallel branch.
5556
# If reset to a branch that was originally cancelled, all the descendants of the previously completed branch will still
5657
# appear in the tree, potentially corrupting the structure and data.

0 commit comments

Comments
 (0)