PR Feedback

Author: matteius

pyproject.toml

@@ -39,7 +39,7 @@ dependencies = [
 ]
 
 [project.optional-dependencies]
-cli = ["click"]
+cli = ["click", "colorama"]
 tests = [
     "pytest",
     "pytest-timeout",

src/pythonfinder/cli.py

@@ -1,16 +1,35 @@
 from __future__ import annotations
 
 import argparse
+import os
+import platform
 import sys
 
 from . import __version__
 from .pythonfinder import Finder
 
+# Use colorama for cross-platform color support if available
+try:
+    import colorama
+    colorama.init()
+    HAS_COLORAMA = True
+except ImportError:
+    HAS_COLORAMA = False
+
 
 def colorize(text: str, color: str | None = None, bold: bool = False) -> str:
     """
     Simple function to colorize text for terminal output.
+
+    Uses colorama for cross-platform support if available.
+    Falls back to ANSI escape codes on Unix/Linux systems.
+    On Windows without colorama, returns plain text.
     """
+    # Check if colors should be disabled
+    if "ANSI_COLORS_DISABLED" in os.environ:
+        return text
+
+    # Define ANSI color codes
     colors = {
         "red": "\033[31m",
         "green": "\033[32m",
@@ -25,9 +44,14 @@ def colorize(text: str, color: str | None = None, bold: bool = False) -> str:
     bold_code = "\033[1m" if bold else ""
     color_code = colors.get(color, "")
 
+    # If no color or bold requested, return plain text
     if not color_code and not bold:
         return text
 
+    # On Windows without colorama, return plain text
+    if platform.system() == "Windows" and not HAS_COLORAMA:
+        return text
+
     return f"{bold_code}{color_code}{text}{reset}"
 
 

src/pythonfinder/models/python_info.py

@@ -20,7 +20,7 @@ class PythonInfo:
 
     path: Path
     version_str: str
-    major: int
+    major: int | None
     minor: int | None = None
     patch: int | None = None
     is_prerelease: bool = False
@@ -49,7 +49,7 @@ def as_python(self) -> PythonInfo:
         return self
 
     @property
-    def version_tuple(self) -> tuple[int, int | None, int | None, bool, bool, bool]:
+    def version_tuple(self) -> tuple[int | None, int | None, int | None, bool, bool, bool]:
         """
         Provides a version tuple for using as a dictionary key.
         """
@@ -79,7 +79,7 @@ def version_sort(self) -> tuple[int, int, int, int, int]:
             release_sort = 1
         return (
             company_sort,
-            self.major,
+            self.major or 0,  # Handle None case by defaulting to 0
             self.minor or 0,
             self.patch or 0,
             release_sort,
@@ -143,7 +143,7 @@ def as_dict(self) -> dict[str, Any]:
         Convert this PythonInfo to a dictionary.
         """
         return {
-            "major": self.major,
+            "major": self.major,  # Can be None
             "minor": self.minor,
             "patch": self.patch,
             "is_prerelease": self.is_prerelease,