fixed edge case for percentage parsing

Suhas Hariharan · Suhas Hariharan · commit 3e56d4d458ae · 2021-12-19T16:35:03.000+08:00
Signed-off-by: Suhas Hariharan &lt;hariharan774531@sas.edu.sg&gt;
diff --git a/src/js/helpers.js b/src/js/helpers.js
@@ -150,7 +150,7 @@ function extractFinalPercent (html) {
         let current_string = html.match(/(?=document\.write).*/g)[1];
         current_string = /\[.*\]/g.exec(current_string)[0].slice(1, -1);
         const temp = current_string.split(";");
-        number = Math.max(isNaN(temp[temp.length - 2]) ? -Infinity : parseFloat(temp[temp.length - 2]), isNaN(temp[temp.length - 1]) ? -Infinity : parseFloat(temp[temp.length - 1]));
+        number = Math.max(isNaN(parseFloat(temp[temp.length - 2])) ? -Infinity : parseFloat(temp[temp.length - 2]), isNaN(parseFloat(temp[temp.length - 1])) ? -Infinity : parseFloat(temp[temp.length - 1]));
     } catch (e) {
         return;
     }

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ function extractFinalPercent (html) {`
`150`	`150`	`let current_string = html.match(/(?=document\.write).*/g)[1];`
`151`	`151`	`current_string = /\[.*\]/g.exec(current_string)[0].slice(1, -1);`
`152`	`152`	`const temp = current_string.split(";");`
`153`		`- number = Math.max(isNaN(temp[temp.length - 2]) ? -Infinity : parseFloat(temp[temp.length - 2]), isNaN(temp[temp.length - 1]) ? -Infinity : parseFloat(temp[temp.length - 1]));`
	`153`	`+ number = Math.max(isNaN(parseFloat(temp[temp.length - 2])) ? -Infinity : parseFloat(temp[temp.length - 2]), isNaN(parseFloat(temp[temp.length - 1])) ? -Infinity : parseFloat(temp[temp.length - 1]));`
`154`	`154`	`} catch (e) {`
`155`	`155`	`return;`
`156`	`156`	`}`