Skip to content

Commit 446224d

Browse files
committed
Fix version name not being set
Signed-off-by: Gary Kim <[email protected]>
1 parent e92a5f5 commit 446224d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

webpack-helpers.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ module.exports = {
66
setManifestVersion: function(contents, version, version_name) {
77
let manifest = JSON.parse(contents);
88
manifest.version = version;
9-
if (typeof version_name !== 'undefined') {
10-
manifest.version_name = version_name;
9+
if (version_name) {
10+
manifest.version_name = this.versionName();
1111
}
1212
return JSON.stringify(manifest);
1313
},

webpack.chromium.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ module.exports = merge(common, {
1313
from: path.join(__dirname, 'src', 'manifest - chromium.json'),
1414
to: 'manifest.json',
1515
transform(content) {
16-
return helpers.setManifestVersion(content, package.version, package.version_name)
16+
return helpers.setManifestVersion(content, package.version, true)
1717
}
1818
}
1919
])

0 commit comments

Comments
 (0)