Merge pull request #181 from gary-kim/cumulative-gpa-fix

Suhas Hariharan · web-flow · commit 4fed692f4a50 · 2020-05-04T08:47:55.000+08:00
Fixes cumulative GPA counting older version of semester
diff --git a/src/js/components/CumulativeGPA.vue b/src/js/components/CumulativeGPA.vue
@@ -200,11 +200,11 @@ export default {
                                 }
                             }
                         }
-                        // Handles edge case where grade history page is updated before semester end
+                        // Handles edge case where grade history page is updated before semester end, removes the old value and counts the latest version of the current semester.
                         if (current_term_history === current_term && include_current_semester && current_term_grades.length === 2 && current_semester) {
-                            include_current_semester = false;
+                            all_courses.splice(all_courses.indexOf(current_term_grades[1]), 1);
                         } else if (current_term_history === current_term && include_current_semester && current_term_grades.length === 1 && current_semester === false) {
-                            include_current_semester = false;
+                            all_courses.splice(all_courses.indexOf(current_term_grades[0]), 1);
                         }
 
                         if (include_current_semester) {

Original file line number	Diff line number	Diff line change
`@@ -200,11 +200,11 @@ export default {`
`200`	`200`	`}`
`201`	`201`	`}`
`202`	`202`	`}`
`203`		`- // Handles edge case where grade history page is updated before semester end`
	`203`	`+ // Handles edge case where grade history page is updated before semester end, removes the old value and counts the latest version of the current semester.`
`204`	`204`	`if (current_term_history === current_term && include_current_semester && current_term_grades.length === 2 && current_semester) {`
`205`		`- include_current_semester = false;`
	`205`	`+ all_courses.splice(all_courses.indexOf(current_term_grades[1]), 1);`
`206`	`206`	`} else if (current_term_history === current_term && include_current_semester && current_term_grades.length === 1 && current_semester === false) {`
`207`		`- include_current_semester = false;`
	`207`	`+ all_courses.splice(all_courses.indexOf(current_term_grades[0]), 1);`
`208`	`208`	`}`
`209`	`209`
`210`	`210`	`if (include_current_semester) {`