Skip to content

Commit 8f48390

Browse files
author
Suhas Hariharan
committed
Fixes cumulative GPA counting older version of semester
Signed-off-by: Suhas Hariharan <[email protected]>
1 parent e92a5f5 commit 8f48390

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/js/components/CumulativeGPA.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ export default {
151151
el.innerHTML = data;
152152
const current_term_history = el.getElementsByClassName("selected")[0].textContent.split(" - ")[0];
153153
const tabs = el.getElementsByClassName("tabs")[0].getElementsByTagName("li");
154-
// Iterate until the end of tabs or until no longer at a high school semester
154+
// Iterate until the end of tabs or until no longer at a high school semester, first value indicates whether the course list is the most recent set of courses
155155
for (let i = 0; i < tabs.length && /HS$/.test(tabs[i].innerText); i++) {
156156
fetches.push(
157157
fetch(tabs[i].getElementsByTagName("a")[0].href)
@@ -202,9 +202,9 @@ export default {
202202
}
203203
// Handles edge case where grade history page is updated before semester end
204204
if (current_term_history === current_term && include_current_semester && current_term_grades.length === 2 && current_semester) {
205-
include_current_semester = false;
205+
all_courses.splice(all_courses.indexOf(current_term_grades[1]), 1);
206206
} else if (current_term_history === current_term && include_current_semester && current_term_grades.length === 1 && current_semester === false) {
207-
include_current_semester = false;
207+
all_courses.splice(all_courses.indexOf(current_term_grades[0]), 1);
208208
}
209209
210210
if (include_current_semester) {

0 commit comments

Comments
 (0)