Fix incorrect GPA conversion when grade is F

Signed-off-by: Gary Kim <[email protected]>

Author: gary-kim

src/js/__tests__/parsers.js

@@ -101,6 +101,18 @@ test('Grade to GPA without Weighting', t => {
         {
             i: "P",
             o: -1
+        },
+        {
+            i: "",
+            o: -1
+        },
+        {
+            i: "asdjfh",
+            o: -1
+        },
+        {
+            i: 182.2,
+            o: -1
         }
     ];
 
@@ -152,6 +164,18 @@ test('Grade to Final Percent', t => {
         {
             i: "P",
             o: -1
+        },
+        {
+            i: "",
+            o: -1
+        },
+        {
+            i: "asdjfh",
+            o: -1
+        },
+        {
+            i: 182.2,
+            o: -1
         }
     ];
 

src/js/helpers.js

@@ -41,7 +41,12 @@ const grade_gpa = {
  * @param {string} grade The grade to convert.
  * @returns {number} The corresponding grade point average.
  */
-const gradeToGPA = grade => grade_gpa[grade] || -1;
+function gradeToGPA(grade) {
+    if (grade in grade_gpa) {
+        return grade_gpa[grade];
+    }
+    return -1;
+}
 
 const grade_fp = {
     'A+': 90,
@@ -60,7 +65,12 @@ const grade_fp = {
  * @param {string} grade The grade to convert.
  * @returns {number} The corresponding final percent.
  */
-const gradeToFP = grade => grade_fp[grade] || -1;
+function gradeToFP(grade) {
+    if (grade in grade_fp) {
+        return grade_fp[grade];
+    }
+    return -1;
+}
 
 const avaliableGrades = ["A+", "A", "B+", "B", "C+", "C", "D+", "D", "F"];