MNT: remove unnecessary if statement

sasaki77 · sasaki77 · commit 4db9c4b8fcae · 2025-10-27T01:04:25.000Z
diff --git a/pkg/archiverappliance/aaclient.go b/pkg/archiverappliance/aaclient.go
@@ -143,19 +143,16 @@ func archiverSingleQuery(queryUrl string) (io.ReadCloser, error) {
 	}
 
 	// Return if response is valid
+	// httpResponse must be closed by caller
 	if httpResponse.StatusCode == http.StatusOK {
 		return httpResponse.Body, nil
 	}
 
 	// Error handling
 	defer httpResponse.Body.Close()
 
-	if httpResponse.StatusCode != http.StatusOK {
-		err := fmt.Errorf("required=200, received=%d: %w", httpResponse.StatusCode, errResponseStatusCode)
-		return nil, err
-	}
-
-	return nil, fmt.Errorf("get request has failed with unexpected error")
+	err := fmt.Errorf("required=200, received=%d: %w", httpResponse.StatusCode, errResponseStatusCode)
+	return nil, err
 }
 
 func buildRegexUrl(regex string, baseURL string, limit int) string {

Original file line number	Diff line number	Diff line change
`@@ -143,19 +143,16 @@ func archiverSingleQuery(queryUrl string) (io.ReadCloser, error) {`
`143`	`143`	`}`
`144`	`144`
`145`	`145`	`// Return if response is valid`
	`146`	`+ // httpResponse must be closed by caller`
`146`	`147`	`if httpResponse.StatusCode == http.StatusOK {`
`147`	`148`	`return httpResponse.Body, nil`
`148`	`149`	`}`
`149`	`150`
`150`	`151`	`// Error handling`
`151`	`152`	`defer httpResponse.Body.Close()`
`152`	`153`
`153`		`- if httpResponse.StatusCode != http.StatusOK {`
`154`		`- err := fmt.Errorf("required=200, received=%d: %w", httpResponse.StatusCode, errResponseStatusCode)`
`155`		`- return nil, err`
`156`		`- }`
`157`		`-`
`158`		`- return nil, fmt.Errorf("get request has failed with unexpected error")`
	`154`	`+ err := fmt.Errorf("required=200, received=%d: %w", httpResponse.StatusCode, errResponseStatusCode)`
	`155`	`+ return nil, err`
`159`	`156`	`}`
`160`	`157`
`161`	`158`	`func buildRegexUrl(regex string, baseURL string, limit int) string {`