[TASK] Simplify condition if in FunctionalTestCase class

sabbelasichon · sabbelasichon · commit 051892cb2e63 · 2024-02-07T16:42:21.000+01:00
diff --git a/src/Rule/ContainerInterfacePrivateServiceRule.php b/src/Rule/ContainerInterfacePrivateServiceRule.php
@@ -60,7 +60,7 @@ private function shouldSkip(MethodCall $node, Scope $scope): bool
 		$isPsrContainerType = (new ObjectType('Psr\Container\ContainerInterface'))->isSuperTypeOf($argType);
 		$isTestCaseType = (new ObjectType('TYPO3\TestingFramework\Core\Functional\FunctionalTestCase'))->isSuperTypeOf($argType);
 
-		if ($isPsrContainerType->yes() && $isTestCaseType->yes()) {
+		if ($isTestCaseType->yes()) {
 			return true;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ private function shouldSkip(MethodCall $node, Scope $scope): bool`
`60`	`60`	`$isPsrContainerType = (new ObjectType('Psr\Container\ContainerInterface'))->isSuperTypeOf($argType);`
`61`	`61`	`$isTestCaseType = (new ObjectType('TYPO3\TestingFramework\Core\Functional\FunctionalTestCase'))->isSuperTypeOf($argType);`
`62`	`62`
`63`		`- if ($isPsrContainerType->yes() && $isTestCaseType->yes()) {`
	`63`	`+ if ($isTestCaseType->yes()) {`
`64`	`64`	`return true;`
`65`	`65`	`}`
`66`	`66`