TASK: Add test for SiteAttributeValidationRule

Author: sabbelasichon

src/Rule/SiteAttributeValidationRule.php

@@ -29,6 +29,9 @@ public function getNodeType(): string
 		return Node\Expr\MethodCall::class;
 	}
 
+	/**
+	 * @param Node\Expr\MethodCall $node
+	 */
 	public function processNode(Node $node, Scope $scope): array
 	{
 		if (!$node->name instanceof Node\Identifier) {
@@ -42,7 +45,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$declaringClass = $methodReflection->getDeclaringClass();
 
-		if (!$declaringClass->implementsInterface(Site::class) && $declaringClass->getName() !== Site::class) {
+		if ($declaringClass->getName() !== Site::class) {
 			return [];
 		}
 

tests/Unit/Rule/SiteAttributeValidationRule/Fixture/UseSiteWithDefinedAttribute.php

@@ -0,0 +1,38 @@
+<?php declare(strict_types = 1);
+
+namespace SaschaEgerer\PhpstanTypo3\Tests\Unit\Rule\SiteAttributeValidationRule\Fixture;
+
+use TYPO3\CMS\Core\Site\Entity\Site;
+
+final class UseSiteWithDefinedAttribute
+{
+
+	/** @var Site */
+	private $site;
+
+	public function __construct(Site $site)
+	{
+		$this->site = $site;
+	}
+
+	public function someMethod(): void
+	{
+		$this->site->getAttribute('languages');
+
+		$this->site->getLanguageById(1);
+
+		$classWithGetAttributeMethod = new class {
+
+			public function getAttribute(string $attributeName): string
+			{
+				return 'foo';
+			}
+
+		};
+
+		$classWithGetAttributeMethod->getAttribute('foo');
+
+		$this->site->getAttribute();
+	}
+
+}

tests/Unit/Rule/SiteAttributeValidationRule/Fixture/UseSiteWithUndefinedAttribute.php

@@ -0,0 +1,23 @@
+<?php declare(strict_types = 1);
+
+namespace SaschaEgerer\PhpstanTypo3\Tests\Unit\Rule\SiteAttributeValidationRule\Fixture;
+
+use TYPO3\CMS\Core\Site\Entity\Site;
+
+final class UseSiteWithUndefinedAttribute
+{
+
+	/** @var Site */
+	private $site;
+
+	public function __construct(Site $site)
+	{
+		$this->site = $site;
+	}
+
+	public function someMethod(): void
+	{
+		$this->site->getAttribute('foo');
+	}
+
+}

tests/Unit/Rule/SiteAttributeValidationRule/SiteAttributeValidationRuleTest.php

@@ -0,0 +1,41 @@
+<?php declare(strict_types = 1);
+
+namespace SaschaEgerer\PhpstanTypo3\Tests\Unit\Rule\SiteAttributeValidationRule;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use SaschaEgerer\PhpstanTypo3\Rule\SiteAttributeValidationRule;
+
+/**
+ * @extends RuleTestCase<SiteAttributeValidationRule>
+ */
+final class SiteAttributeValidationRuleTest extends RuleTestCase
+{
+
+	public function testRuleWithoutErrors(): void
+	{
+		$this->analyse([__DIR__ . '/Fixture/UseSiteWithDefinedAttribute.php'], []);
+	}
+
+	public function testRuleWithErrors(): void
+	{
+		$this->analyse(
+			[__DIR__ . '/Fixture/UseSiteWithUndefinedAttribute.php'],
+			[
+				[
+					'There is no site attribute "foo" configured so we can\'t figure out the exact type to return when calling TYPO3\CMS\Core\Site\Entity\Site::getAttribute',
+					20,
+					'You should add custom site attribute to the typo3.siteGetAttributeMapping setting.',
+				],
+			]
+		);
+	}
+
+	protected function getRule(): Rule
+	{
+		return new SiteAttributeValidationRule([
+			'languages' => 'de',
+		]);
+	}
+
+}