Fixed class paths in context getAspect mapping (#55)

Co-authored-by: Sascha Egerer <[email protected]>

Author: tlueder

README.md

@@ -34,5 +34,5 @@ what type of aspect class is returned by the context API
 parameters:
     typo3:
         contextApiGetAspectMapping:
-            myCustomAspect: \FlowdGmbh\MyProject\Context\MyCustomAspect
+            myCustomAspect: FlowdGmbh\MyProject\Context\MyCustomAspect
 ```

extension.neon

@@ -52,13 +52,13 @@ parameters:
         - phpstan.bootstrap.php
     typo3:
         contextApiGetAspectMapping:
-            date: \TYPO3\CMS\Core\Context\DateTimeAspect
-            visibility: \TYPO3\CMS\Core\Context\VisibilityAspect
-            backend.user: \TYPO3\CMS\Core\Context\UserAspect
-            frontend.user: \TYPO3\CMS\Core\Context\UserAspect
-            workspace: \TYPO3\CMS\Core\Context\WorkspaceAspect
-            language: \TYPO3\CMS\Core\Context\LanguageAspect
-            typoscript: \TYPO3\CMS\Core\Context\TypoScriptAspect
+            date: TYPO3\CMS\Core\Context\DateTimeAspect
+            visibility: TYPO3\CMS\Core\Context\VisibilityAspect
+            backend.user: TYPO3\CMS\Core\Context\UserAspect
+            frontend.user: TYPO3\CMS\Core\Context\UserAspect
+            workspace: TYPO3\CMS\Core\Context\WorkspaceAspect
+            language: TYPO3\CMS\Core\Context\LanguageAspect
+            typoscript: TYPO3\CMS\Core\Context\TypoScriptAspect
     stubFiles:
         - stubs/DomainObjectInterface.stub
         - stubs/GeneralUtility.stub

tests/Unit/Type/ContextDynamicReturnTypeExtensionTest.php

@@ -0,0 +1,39 @@
+<?php declare(strict_types = 1);
+
+namespace SaschaEgerer\PhpstanTypo3\Tests\Unit\Type;
+
+use PHPStan\Testing\TypeInferenceTestCase;
+
+class ContextDynamicReturnTypeExtensionTest extends TypeInferenceTestCase
+{
+
+	/**
+	 * @return iterable<mixed>
+	 */
+	public function dataFileAsserts(): iterable
+	{
+		// path to a file with actual asserts of expected types:
+		yield from $this->gatherAssertTypes(__DIR__ . '/data/context-get-aspect-return-types.php');
+	}
+
+	/**
+	 * @dataProvider dataFileAsserts
+	 * @param string $assertType
+	 * @param string $file
+	 * @param mixed ...$args
+	 */
+	public function testFileAsserts(
+		string $assertType,
+		string $file,
+		...$args
+	): void
+	{
+		$this->assertFileAsserts($assertType, $file, ...$args);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [__DIR__ . '/../../../extension.neon'];
+	}
+
+}

tests/Unit/Type/data/context-get-aspect-return-types.php

@@ -0,0 +1,32 @@
+<?php declare(strict_types = 1);
+
+namespace ContextGetAspectReturnTypes;
+
+use TYPO3\CMS\Core\Context\Context;
+use TYPO3\CMS\Core\Context\DateTimeAspect;
+use TYPO3\CMS\Core\Context\LanguageAspect;
+use TYPO3\CMS\Core\Context\TypoScriptAspect;
+use TYPO3\CMS\Core\Context\UserAspect;
+use TYPO3\CMS\Core\Context\VisibilityAspect;
+use TYPO3\CMS\Core\Context\WorkspaceAspect;
+
+use function PHPStan\Testing\assertType;
+
+// phpcs:ignore Squiz.Classes.ClassFileName.NoMatch
+class MyContext
+{
+
+	public function getAspectTests(Context $context): void
+	{
+		if (class_exists(TypoScriptAspect::class)) {
+			assertType(TypoScriptAspect::class, $context->getAspect('typoscript'));
+		}
+		assertType(DateTimeAspect::class, $context->getAspect('date'));
+		assertType(VisibilityAspect::class, $context->getAspect('visibility'));
+		assertType(UserAspect::class, $context->getAspect('backend.user'));
+		assertType(UserAspect::class, $context->getAspect('frontend.user'));
+		assertType(WorkspaceAspect::class, $context->getAspect('workspace'));
+		assertType(LanguageAspect::class, $context->getAspect('language'));
+	}
+
+}