Run phpcs on tests folder

Author: sascha-egerer

phpcs.xml

@@ -1,11 +1,12 @@
 <?xml version="1.0"?>
-<ruleset name="PHPStan">
+<ruleset name="Source">
 	<arg name="colors"/>
 	<arg name="extensions" value="php"/>
 	<arg name="encoding" value="utf-8"/>
 	<arg name="tab-width" value="4"/>
 	<arg value="sp"/>
 	<file>src</file>
+	<file>tests</file>
 
 	<rule ref="vendor/consistence-community/coding-standard/Consistence/ruleset.xml">
 		<exclude name="SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration.InvalidFormat"/>

tests/Unit/Type/QueryFactoryStubFileTest.php

@@ -17,6 +17,8 @@ public function dataFileAsserts(): iterable
 
 	/**
 	 * @dataProvider dataFileAsserts
+	 * @param string $assertType
+	 * @param string $file
 	 * @param mixed ...$args
 	 */
 	public function testFileAsserts(

tests/Unit/Type/RepositoryQueryDynamicReturnTypeExtensionTest.php

@@ -17,7 +17,9 @@ public function dataFileAsserts(): iterable
 
 	/**
 	 * @dataProvider dataFileAsserts
-	 * @param mixed $args
+	 * @param string $assertType
+	 * @param string $file
+	 * @param mixed ...$args
 	 */
 	public function testFileAsserts(
 		string $assertType,

tests/Unit/Type/RepositoryStubFileTest.php

@@ -17,6 +17,8 @@ public function dataFileAsserts(): iterable
 
 	/**
 	 * @dataProvider dataFileAsserts
+	 * @param string $assertType
+	 * @param string $file
 	 * @param mixed ...$args
 	 */
 	public function testFileAsserts(

tests/Unit/Type/data/custom-query-type.php

@@ -1,26 +1,30 @@
 <?php declare(strict_types = 1);
 
+// phpcs:disable SlevomatCodingStandard.Namespaces.RequireOneNamespaceInFile.MoreNamespacesInFile
+// phpcs:disable Squiz.Classes.ClassFileName.NoMatch
+// phpcs:disable PSR1.Classes.ClassDeclaration.MultipleClasses
+
 namespace CustomQueryType\My\Test\Extension\Domain\Model;
 
 use TYPO3\CMS\Extbase\DomainObject\AbstractEntity;
 
-	// Extbase naming convention says this model should be called MyModel, but we want to test that it also works if we
-	// have a different model name
+// Extbase naming convention says this model should be called MyModel, but we want to test that it also works if we
+// have a different model name
 class SomeOtherModel extends AbstractEntity
 {
 
 }
 
 namespace CustomQueryType\My\Test\Extension\Domain\Repository;
 
-	use CustomQueryType\My\Test\Extension\Domain\Model\SomeOtherModel;
-	use TYPO3\CMS\Extbase\Persistence\QueryInterface;
-	use TYPO3\CMS\Extbase\Persistence\Repository;
-	use function PHPStan\Testing\assertType;
+use CustomQueryType\My\Test\Extension\Domain\Model\SomeOtherModel;
+use TYPO3\CMS\Extbase\Persistence\QueryInterface;
+use TYPO3\CMS\Extbase\Persistence\Repository;
+use function PHPStan\Testing\assertType;
 
-	/**
-	 * @extends Repository<SomeOtherModel>
-	 */
+/**
+ * @extends Repository<SomeOtherModel>
+ */
 class MyModelRepository extends Repository
 {
 

tests/Unit/Type/data/query-factory-stub-files.php

@@ -2,29 +2,26 @@
 
 namespace QueryFactoryStubFile;
 
-use Psr\Container\ContainerInterface;
-use TYPO3\CMS\Extbase\Configuration\ConfigurationManager;
-use TYPO3\CMS\Extbase\Persistence\Generic\Mapper\DataMapFactory;
 use TYPO3\CMS\Extbase\Persistence\Generic\QueryFactory;
+use function PHPStan\Testing\assertType;
 
+// phpcs:ignore Squiz.Classes.ClassFileName.NoMatch
 class Model extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity
 {
 
-}
+	public function foo(): void
+	{
+		$createResult = $this->getQueryFactory()->create(self::class);
 
-use function PHPStan\Testing\assertType;
+		assertType('TYPO3\CMS\Extbase\Persistence\QueryInterface<QueryFactoryStubFile\Model>', $createResult);
+		assertType('class-string<' . self::class . '>', $createResult->getType());
+	}
 
-static function (): void {
-	/** @var ConfigurationManager $configurationManager */
-	$configurationManager = null;
-	/** @var DataMapFactory $dataMapFactory */
-	$dataMapFactory = null;
-	/** @var ContainerInterface $containerInterface */
-	$containerInterface = null;
+	private function getQueryFactory(): QueryFactory
+	{
+		/** @var QueryFactory $queryFactory */
+		$queryFactory = null;
+		return $queryFactory;
+	}
 
-	$queryFactory = new QueryFactory($configurationManager, $dataMapFactory, $containerInterface);
-	$createResult = $queryFactory->create(Model::class);
-
-	assertType('TYPO3\CMS\Extbase\Persistence\QueryInterface<QueryFactoryStubFile\Model>', $createResult);
-	assertType('class-string<' . Model::class . '>', $createResult->getType());
-};
+}

tests/Unit/Type/data/repository-stub-files.php

@@ -1,5 +1,9 @@
 <?php declare(strict_types = 1);
 
+// phpcs:disable SlevomatCodingStandard.Namespaces.RequireOneNamespaceInFile.MoreNamespacesInFile
+// phpcs:disable Squiz.Classes.ClassFileName.NoMatch
+// phpcs:disable PSR1.Classes.ClassDeclaration.MultipleClasses
+
 namespace RepositoryStubFiles\My\Test\Extension\Domain\Model;
 
 class MyModel extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity