Merge pull request #99 from oliverklee/task/performance

sascha-egerer · web-flow · commit 5f72c48ea28d · 2022-10-23T22:52:14.000+02:00
[TASK] Reorder a condition to improve performance
diff --git a/src/Type/RepositoryFindAllDynamicReturnTypeExtension.php b/src/Type/RepositoryFindAllDynamicReturnTypeExtension.php
@@ -40,8 +40,8 @@ public function getTypeFromMethodCall(
 	{
 		$variableType = $scope->getType($methodCall->var);
 
-		if ($methodReflection->getDeclaringClass()->getName() !== Repository::class
-			|| !$variableType instanceof TypeWithClassName) {
+		if (!$variableType instanceof TypeWithClassName
+			|| $methodReflection->getDeclaringClass()->getName() !== Repository::class) {
 			return ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,8 @@ public function getTypeFromMethodCall(`
`40`	`40`	`{`
`41`	`41`	`$variableType = $scope->getType($methodCall->var);`
`42`	`42`
`43`		`- if ($methodReflection->getDeclaringClass()->getName() !== Repository::class`
`44`		`- \|\| !$variableType instanceof TypeWithClassName) {`
	`43`	`+ if (!$variableType instanceof TypeWithClassName`
	`44`	`+ \|\| $methodReflection->getDeclaringClass()->getName() !== Repository::class) {`
`45`	`45`	`return ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();`
`46`	`46`	`}`
`47`	`47`