Merge pull request #116 from sascha-egerer/feauture/114

Load TYPO3 version specific stubs

Author: sascha-egerer

composer.json

@@ -13,7 +13,8 @@
 		"nikic/php-parser": "^4.15.1",
 		"typo3/cms-core": "^10.4 || ^11.5 || ^12.2",
 		"typo3/cms-extbase": "^10.4 || ^11.5 || ^12.2",
-		"bnf/phpstan-psr-container": "^1.0"
+		"bnf/phpstan-psr-container": "^1.0",
+		"composer/semver": "^3.3"
 	},
 	"require-dev": {
 		"consistence-community/coding-standard": "^3.10.1",

extension.neon

@@ -89,6 +89,10 @@ services:
         class: SaschaEgerer\PhpstanTypo3\Type\MathUtilityTypeSpecifyingExtension
         tags:
             - phpstan.typeSpecifier.staticMethodTypeSpecifyingExtension
+    -
+        class: SaschaEgerer\PhpstanTypo3\Stubs\StubFilesExtensionLoader
+        tags:
+            - phpstan.stubFilesExtension
 parameters:
     bootstrapFiles:
         - phpstan.bootstrap.php
@@ -121,13 +125,15 @@ parameters:
             websiteTitle: string
     stubFiles:
         - stubs/DomainObjectInterface.stub
-        - stubs/GeneralUtility.stub
         - stubs/ObjectStorage.stub
         - stubs/QueryFactory.stub
         - stubs/QueryInterface.stub
         - stubs/QueryResultInterface.stub
-        - stubs/QueryResult.stub
         - stubs/Repository.stub
+        # See SaschaEgerer\PhpstanTypo3\Stubs\StubFilesExtensionLoader
+        # GeneralUtility.stub is only used if TYPO3 version is < 12
+        #- stubs/GeneralUtility.stub
+        #- stubs/QueryResult.stub
     dynamicConstantNames:
         - TYPO3_MODE
         - TYPO3_REQUESTTYPE

src/Stubs/StubFilesExtensionLoader.php

@@ -0,0 +1,28 @@
+<?php declare(strict_types = 1);
+
+namespace SaschaEgerer\PhpstanTypo3\Stubs;
+
+use Composer\Semver\VersionParser;
+use TYPO3\CMS\Core\Information\Typo3Version;
+
+class StubFilesExtensionLoader implements \PHPStan\PhpDoc\StubFilesExtension
+{
+
+	public function getFiles(): array
+	{
+		$stubsDir = dirname(__DIR__, 2) . '/stubs';
+		$files = [];
+		$typo3Version = new Typo3Version();
+		$versionParser = new VersionParser();
+
+		if ($versionParser->parseConstraints($typo3Version->getVersion())->matches($versionParser->parseConstraints('< 12'))) {
+			$files[] = $stubsDir . '/GeneralUtility.stub';
+		}
+		if ($versionParser->parseConstraints($typo3Version->getVersion())->matches($versionParser->parseConstraints('<= 12.2.0'))) {
+			$files[] = $stubsDir . '/QueryResult.stub';
+		}
+
+		return $files;
+	}
+
+}