TASK: Also add method getPropertyFromAspect

Author: sabbelasichon

src/Rule/ContextAspectValidationRule.php

@@ -38,7 +38,12 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$methodReflection = $scope->getMethodReflection($scope->getType($node->var), $node->name->toString());
-		if ($methodReflection === null || $methodReflection->getName() !== 'getAspect') {
+
+		if ($methodReflection === null) {
+			return [];
+		}
+
+		if (!in_array($methodReflection->getName(), ['getAspect', 'getPropertyFromAspect'], true)) {
 			return [];
 		}
 

tests/Unit/Rule/ContextAspectValidationRule/ContextAspectValidationRuleTest.php

@@ -1,10 +1,7 @@
-<?php
-declare(strict_types=1);
-
+<?php declare(strict_types = 1);
 
 namespace SaschaEgerer\PhpstanTypo3\Tests\Unit\Rule\ContextAspectValidationRule;
 
-
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 use SaschaEgerer\PhpstanTypo3\Rule\ContextAspectValidationRule;
@@ -15,23 +12,29 @@
  */
 final class ContextAspectValidationRuleTest extends RuleTestCase
 {
+
 	public function testRuleWithErrors(): void
 	{
 		$this->analyse(
-			[__DIR__.'/Fixture/UseContextApiWithUndefinedAspect.php'],
+			[__DIR__ . '/Fixture/UseContextApiWithUndefinedAspect.php'],
 			[
 				[
 					'There is no aspect "foo" configured so we can\'t figure out the exact type to return when calling TYPO3\CMS\Core\Context\Context::getAspect',
-					15,
-					'You should add custom aspects to the typo3.contextApiGetAspectMapping setting.'
+					13,
+					'You should add custom aspects to the typo3.contextApiGetAspectMapping setting.',
+				],
+				[
+					'There is no aspect "dates" configured so we can\'t figure out the exact type to return when calling TYPO3\CMS\Core\Context\Context::getPropertyFromAspect',
+					16,
+					'You should add custom aspects to the typo3.contextApiGetAspectMapping setting.',
 				],
 			]
 		);
 	}
 
 	public static function getAdditionalConfigFiles(): array
 	{
-		return [__DIR__.'/../../../../extension.neon'];
+		return [__DIR__ . '/../../../../extension.neon'];
 	}
 
 	public function testRuleWithoutErrors(): void
@@ -42,7 +45,8 @@ public function testRuleWithoutErrors(): void
 	protected function getRule(): Rule
 	{
 		return new ContextAspectValidationRule([
-			'date' =>  DateTimeAspect::class
+			'date' => DateTimeAspect::class,
 		]);
 	}
+
 }

tests/Unit/Rule/ContextAspectValidationRule/Fixture/UseContextApiWithDefinedAspect.php

@@ -1,26 +1,26 @@
-<?php
-declare(strict_types=1);
-
+<?php declare(strict_types = 1);
 
 namespace SaschaEgerer\PhpstanTypo3\Tests\Unit\Rule\ContextAspectValidationRule\Fixture;
 
-
 use TYPO3\CMS\Core\Context\Context;
 use TYPO3\CMS\Core\Context\DateTimeAspect;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 final class UseContextApiWithDefinedAspect
 {
+
 	public function someMethod(): void
 	{
 		$dateAspect = GeneralUtility::makeInstance(Context::class)->getAspect('date');
 		$dateAspect->get('bar');
 
 		$class = new class {
+
 			public function getAspect(string $name): \stdClass
 			{
 				return new \stdClass();
 			}
+
 		};
 
 		$myCustomAspect = $class->getAspect('foo');
@@ -30,7 +30,6 @@ public function getAspect(string $name): \stdClass
 		$aspectWithoutDefiningName->get('bar');
 
 		GeneralUtility::makeInstance(Context::class)->setAspect('dates', new DateTimeAspect(new \DateTimeImmutable()));
-
-		GeneralUtility::makeInstance(Context::class)->getPropertyFromAspect('dates', 'foo');
 	}
+
 }

tests/Unit/Rule/ContextAspectValidationRule/Fixture/UseContextApiWithUndefinedAspect.php

@@ -1,18 +1,19 @@
-<?php
-declare(strict_types=1);
-
+<?php declare(strict_types = 1);
 
 namespace SaschaEgerer\PhpstanTypo3\Tests\Unit\Rule\ContextAspectValidationRule\Fixture;
 
-
 use TYPO3\CMS\Core\Context\Context;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 final class UseContextApiWithUndefinedAspect
 {
+
 	public function someMethod(): void
 	{
 		$foo = GeneralUtility::makeInstance(Context::class)->getAspect('foo');
 		$foo->get('bar');
+
+		GeneralUtility::makeInstance(Context::class)->getPropertyFromAspect('dates', 'foo');
 	}
+
 }