[TASK] Add check for potential prototype class

Author: sabbelasichon

extension.neon

@@ -106,6 +106,8 @@ services:
             - phpstan.broker.dynamicMethodReturnTypeExtension
     -
     	class: SaschaEgerer\PhpstanTypo3\Service\PrivateServiceAnalyzer
+    -
+        class: SaschaEgerer\PhpstanTypo3\Service\PrototypeServiceDefinitionChecker
     # service map
     typo3.serviceMapFactory:
         class: SaschaEgerer\PhpstanTypo3\Contract\ServiceMapFactory

src/Contract/ServiceDefinitionChecker.php

@@ -2,11 +2,16 @@
 
 namespace SaschaEgerer\PhpstanTypo3\Contract;
 
+use PhpParser\Node;
+use PhpParser\Node\Expr\StaticCall;
 use SaschaEgerer\PhpstanTypo3\Service\ServiceDefinition;
 
 interface ServiceDefinitionChecker
 {
 
-	public function isPrototype(ServiceDefinition $serviceDefinition): bool;
+	/**
+	 * @param Node\Expr\MethodCall|StaticCall $node
+	 */
+	public function isPrototype(ServiceDefinition $serviceDefinition, Node $node): bool;
 
 }

src/Rule/GeneralUtilityMakeInstancePrivateServiceRule.php

@@ -18,9 +18,12 @@ final class GeneralUtilityMakeInstancePrivateServiceRule implements Rule
 
 	private PrivateServiceAnalyzer $privateServiceAnalyzer;
 
-	public function __construct(PrivateServiceAnalyzer $privateServiceAnalyzer)
+	private PrototypeServiceDefinitionChecker $prototypeServiceDefinitionChecker;
+
+	public function __construct(PrivateServiceAnalyzer $privateServiceAnalyzer, PrototypeServiceDefinitionChecker $prototypeServiceDefinitionChecker)
 	{
 		$this->privateServiceAnalyzer = $privateServiceAnalyzer;
+		$this->prototypeServiceDefinitionChecker = $prototypeServiceDefinitionChecker;
 	}
 
 	public function getNodeType(): string
@@ -34,7 +37,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		return $this->privateServiceAnalyzer->analyze($node, $scope, new PrototypeServiceDefinitionChecker());
+		return $this->privateServiceAnalyzer->analyze($node, $scope, $this->prototypeServiceDefinitionChecker);
 	}
 
 	private function shouldSkip(StaticCall $node): bool

src/Service/NullServiceDefinitionChecker.php

@@ -2,12 +2,13 @@
 
 namespace SaschaEgerer\PhpstanTypo3\Service;
 
+use PhpParser\Node;
 use SaschaEgerer\PhpstanTypo3\Contract\ServiceDefinitionChecker;
 
 final class NullServiceDefinitionChecker implements ServiceDefinitionChecker
 {
 
-	public function isPrototype(ServiceDefinition $serviceDefinition): bool
+	public function isPrototype(ServiceDefinition $serviceDefinition, Node $node): bool
 	{
 		return false;
 	}

src/Service/PrivateServiceAnalyzer.php

@@ -40,7 +40,7 @@ public function analyze(Node $node, Scope $scope, ServiceDefinitionChecker $serv
 			return [];
 		}
 
-		if ($serviceDefinitionChecker->isPrototype($serviceDefinition)) {
+		if ($serviceDefinitionChecker->isPrototype($serviceDefinition, $node)) {
 			return [];
 		}
 

src/Service/PrototypeServiceDefinitionChecker.php

@@ -2,14 +2,73 @@
 
 namespace SaschaEgerer\PhpstanTypo3\Service;
 
+use PhpParser\Node;
+use PhpParser\Node\Expr\ClassConstFetch;
+use PhpParser\Node\Expr\StaticCall;
 use SaschaEgerer\PhpstanTypo3\Contract\ServiceDefinitionChecker;
 
 final class PrototypeServiceDefinitionChecker implements ServiceDefinitionChecker
 {
 
-	public function isPrototype(ServiceDefinition $serviceDefinition): bool
+	public function isPrototype(ServiceDefinition $serviceDefinition, Node $node): bool
 	{
-		return !$serviceDefinition->isHasTags() && !$serviceDefinition->isHasMethodCalls() && !$serviceDefinition->isHasConstructorArguments();
+		return !$serviceDefinition->isHasTags() && !$serviceDefinition->isHasMethodCalls() && !$serviceDefinition->isHasConstructorArguments() && !$this->canBePrototypeClass($node);
+	}
+
+	private function extractFirstArgument(StaticCall $node): ?Node
+	{
+		if (!isset($node->args[0])) {
+			return null;
+		}
+
+		if (!$node->args[0] instanceof Node\Arg) {
+			return null;
+		}
+
+		return $node->args[0]->value;
+	}
+
+	private function canBePrototypeClass(Node $node): bool
+	{
+		if (!$node instanceof StaticCall) {
+			return false;
+		}
+
+		$firstArgument = $this->extractFirstArgument($node);
+
+		if (!$firstArgument instanceof ClassConstFetch) {
+			return false;
+		}
+
+		if (!$firstArgument->class instanceof Node\Name) {
+			return false;
+		}
+
+		if ($firstArgument->class->isSpecialClassName()) {
+			return false;
+		}
+
+		/** @var class-string $className */
+		$className = $firstArgument->class->toString();
+
+		$reflection = new \ReflectionClass($className);
+
+		$constructorMethod = $reflection->getConstructor();
+
+		if ($constructorMethod === null) {
+			return true;
+		}
+
+		$constructorParameters = $constructorMethod->getParameters();
+		$hasRequiredParameter = false;
+		foreach ($constructorParameters as $constructorParameter) {
+			if ($constructorParameter->isOptional()) {
+				continue;
+			}
+			$hasRequiredParameter = true;
+		}
+
+		return $hasRequiredParameter === false;
 	}
 
 }