Skip to content

Commit c6c2a90

Browse files
Merge pull request #163 from sascha-egerer/bugfix/fix-query-execute-return-type
Fix return type of QueryInterface::execute()
2 parents b1c8f18 + 61cdb6d commit c6c2a90

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

tests/Unit/Type/data/custom-query-type.php

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,27 @@ class SomeOtherModel extends AbstractEntity
2828
class MyModelRepository extends Repository
2929
{
3030

31-
public function findBySomething(): void
31+
public function findBySomething(bool $booleanParameter = false): void
3232
{
3333
/** @var QueryInterface<SomeOtherModel> $query */
3434
$query = $this->persistenceManager->createQueryForType(SomeOtherModel::class);
3535

3636
$result = $query->execute();
3737
assertType(
38-
'TYPO3\CMS\Extbase\Persistence\QueryInterface<CustomQueryType\My\Test\Extension\Domain\Model\SomeOtherModel>',
39-
$query
38+
'TYPO3\CMS\Extbase\Persistence\QueryResultInterface<int, CustomQueryType\My\Test\Extension\Domain\Model\SomeOtherModel>',
39+
$result
40+
);
41+
42+
$result = $query->execute(false);
43+
assertType(
44+
'TYPO3\CMS\Extbase\Persistence\QueryResultInterface<int, CustomQueryType\My\Test\Extension\Domain\Model\SomeOtherModel>',
45+
$result
46+
);
47+
48+
$result = $query->execute($booleanParameter);
49+
assertType(
50+
'list<array<string, mixed>>|TYPO3\CMS\Extbase\Persistence\QueryResultInterface<int, CustomQueryType\My\Test\Extension\Domain\Model\SomeOtherModel>',
51+
$result
4052
);
4153

4254
$rawResult = $query->execute(true);

0 commit comments

Comments
 (0)