Skip to content

Commit 0072eb4

Browse files
committed
I agree to a very vague oath about testing
1 parent 141d410 commit 0072eb4

File tree

1 file changed

+12
-0
lines changed
  • keps/sig-api-machinery/2885-server-side-unknown-field-validation

1 file changed

+12
-0
lines changed

keps/sig-api-machinery/2885-server-side-unknown-field-validation/README.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ tags, and then generate with `hack/update-toc.sh`.
9898
- [Apply Patch](#apply-patch)
9999
- [Kubectl Flag](#kubectl-flag)
100100
- [Test Plan](#test-plan)
101+
- [Prerequisite testing updates](#prerequisite-testing-updates)
101102
- [Unit tests](#unit-tests)
102103
- [Integration tests](#integration-tests)
103104
- [e2e tests](#e2e-tests)
@@ -556,6 +557,14 @@ validation is supported by the apiserver kubectl is connected to.
556557

557558
### Test Plan
558559

560+
[X] I/we understand the owners of the involved components may require updates to
561+
existing tests to make this code solid enough prior to committing the changes necessary
562+
to implement this enhancement.
563+
564+
##### Prerequisite testing updates
565+
566+
N/A
567+
559568
<!--
560569
**Note:** *Not required until targeted at a release.*
561570
@@ -574,6 +583,7 @@ when drafting this test plan.
574583
[testing-guidelines]: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md
575584
-->
576585
##### Unit tests
586+
577587
[alpha and beta]
578588
Logic that is changed in the apiextensions schema package (i.e. objectmeta
579589
algorithm and pruning algorithm) will be thoroughly unit tested as well as
@@ -584,6 +594,7 @@ Additional testing has also been added to the
584594
[apiserver/endpoints/handlers/rest_test.go](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/rest_test.go) to detect unknown and duplicate fields.
585595

586596
##### Integration tests
597+
587598
[alpha and beta]
588599
Primarily, server side validation will be integration tested and benchmarked via a complete test
589600
suite at
@@ -599,6 +610,7 @@ It tests the cross product of all valid permutations along the dimensions of:
599610

600611

601612
##### e2e tests
613+
602614
[beta]
603615
With field validation on by default in beta, we will modify
604616
[test/e2e/kubectl/kubectl.go](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/kubectl/kubectl.go) to ensure that kubectl defaults to using server side field validation and detects unknown/duplicate fields as expected.

0 commit comments

Comments
 (0)