Skip to content

Commit 01a2798

Browse files
committed
Add section upgrade/downgrade tests and containerd e2e
Signed-off-by: Sascha Grunert <[email protected]>
1 parent e5653bd commit 01a2798

File tree

1 file changed

+16
-1
lines changed
  • keps/sig-node/4639-oci-volume-source

1 file changed

+16
-1
lines changed

keps/sig-node/4639-oci-volume-source/README.md

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -785,6 +785,10 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
785785

786786
https://testgrid.k8s.io/sig-node-cri-o#pr-crio-cgrpv2-imagevolume-e2e
787787

788+
When [containerd](https://github.com/containerd/containerd/pull/10579) adds
789+
support for the feature, then the e2e tests will become available for that
790+
runtime as well.
791+
788792
### Graduation Criteria
789793

790794
<!--
@@ -1068,7 +1072,18 @@ Longer term, we may want to require automated upgrade/rollback tests, but we
10681072
are missing a bunch of machinery and tooling and can't do that now.
10691073
-->
10701074

1071-
Not yet but they will be.
1075+
Manual testing that will be done:
1076+
1077+
- Upgrade:
1078+
- Enable the feature in the kube-apiserver, kubelet and container runtime
1079+
- Create a workload which uses the feature
1080+
- Verify that the image volume has been mounted.
1081+
1082+
- Rollback:
1083+
- Disable the feature by rolling back the kube-apiserver, kubelet or
1084+
container runtime
1085+
- Recreate the workload, which will now fail because of either the not
1086+
existing API or the unsupported runtime version.
10721087

10731088
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
10741089

0 commit comments

Comments
 (0)