Skip to content

Commit 01ceb8f

Browse files
committed
graduate inter-pod affinity NamespaceSelector to stable
1 parent d452a4b commit 01ceb8f

File tree

3 files changed

+30
-8
lines changed

3 files changed

+30
-8
lines changed

keps/prod-readiness/sig-scheduling/2249.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,5 @@ alpha:
33
approver: "@wojtek-t"
44
beta:
55
approver: "@wojtek-t"
6+
stable:
7+
approver: "@wojtek-t"

keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md

Lines changed: 26 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ To get started with this template:
2424
appropriate SIG(s).
2525
- [x] **Create a PR for this KEP.**
2626
Assign it to people in the SIG who are sponsoring this process.
27-
- [ ] **Merge early and iterate.**
27+
- [x] **Merge early and iterate.**
2828
Avoid getting hung up on specific details and instead aim to get the goals of
2929
the KEP clarified and merged quickly. The best way to do this is to just
3030
start with the high-level sections and fill out details incrementally in
@@ -129,11 +129,11 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
129129
- [x] (R) Design details are appropriately documented
130130
- [x] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
131131
- [x] (R) Graduation criteria is in place
132-
- [ ] (R) Production readiness review completed
133-
- [ ] (R) Production readiness review approved
132+
- [x] (R) Production readiness review completed
133+
- [x] (R) Production readiness review approved
134134
- [x] "Implementation History" section is up-to-date for milestone
135-
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
136-
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
135+
- [x] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
136+
- [x] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
137137

138138
<!--
139139
**Note:** This checklist is iterative and should be reviewed and updated every time this enhancement is being considered for a milestone.
@@ -349,7 +349,7 @@ type PodAffinityTerm struct {
349349
// The term is applied to the union of the namespaces selected by this field
350350
// and the ones listed in the namespaces field.
351351
// nil selector and empty namespaces list means "this pod's namespace"
352-
// An empty selector ({}) is not valid.
352+
// An empty selector ({}) means all namespaces.
353353
NamespaceSelector *metav1.LabelSelector
354354
}
355355
```
@@ -583,6 +583,25 @@ _This section must be completed when targeting beta graduation to a release._
583583
* **How can an operator determine if the feature is in use by workloads?**
584584
The operator can query pods with the NamespaceSelector field set in pod affinity terms.
585585

586+
* **How can someone using this feature know that it is working for their instance?**
587+
<!--
588+
For instance, if this is a pod-related feature, it should be possible to determine if the feature is functioning properly
589+
for each individual pod.
590+
Pick one more of these and delete the rest.
591+
Please describe all items visible to end users below with sufficient detail so that they can verify correct enablement
592+
and operation of this feature.
593+
Recall that end users cannot usually observe component logs or access metrics.
594+
-->
595+
596+
- [x] Other (treat as last resort)
597+
- Details: inter-pod affinity as a feature doesn't trigger pod status updates on its own,
598+
none of the scheduler's filters/scores do on their own. If a pod using affinity
599+
was successfully assigned a node, nodeName will be updated, if not, then
600+
PodScheduled condition will be false, and an event will be recorded with a detailed
601+
message describing the reason including the failed filters (inter-pod affnity could
602+
be one of them).
603+
604+
586605
* **What are the SLIs (Service Level Indicators) an operator can use to determine
587606
the health of the service?**
588607
- [x] Metrics
@@ -686,6 +705,7 @@ information to express the idea and why it was not acceptable.
686705
- 2021-01-11: Initial KEP sent for review
687706
- 2021-02-10: Remove the restriction on empty namespace selector
688707
- 2021-04-26: Graduate the feature to Beta
708+
- 2022-01-08: Graduate the feature to Stable
689709

690710
<!--
691711
Major milestones in the lifecycle of a KEP should be tracked in this section.

keps/sig-scheduling/2249-pod-affinity-namespace-selector/kep.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ prr-approvers:
1919
see-also:
2020

2121
# The target maturity stage in the current dev cycle for this KEP.
22-
stage: beta
22+
stage: stable
2323

2424
# The most recent milestone for which work toward delivery of this KEP has been
2525
# done. This can be the current (upcoming) milestone, if it is being actively
2626
# worked on.
27-
latest-milestone: "v1.22"
27+
latest-milestone: "v1.24"
2828

2929
# The milestone at which this feature was, or is targeted to be, at each stage.
3030
milestone:

0 commit comments

Comments
 (0)