Skip to content

Commit 03ccce9

Browse files
committed
fix based on review
1 parent 580f1c1 commit 03ccce9

File tree

1 file changed

+6
-9
lines changed
  • keps/sig-scheduling/3633-matchlabelkeys-to-podaffinity

1 file changed

+6
-9
lines changed

keps/sig-scheduling/3633-matchlabelkeys-to-podaffinity/README.md

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -492,14 +492,10 @@ https://storage.googleapis.com/k8s-triage/index.html
492492
- `matchLabelKeys`/`mismatchLabelKeys` with the feature gate enabled/disabled.
493493

494494
**Filter**
495-
- `k8s.io/kubernetes/test/integration/scheduler/filters/filters_test.go`: https://storage.googleapis.com/k8s-triage/index.html?test=TestPodTopologySpreadFilter
495+
- [`k8s.io/kubernetes/test/integration/scheduler/filters/filters_test.go`](https://github.com/kubernetes/kubernetes/blob/3a4c35cc89c0ce132f8f5962ce4b9a48fae77873/test/integration/scheduler/filters/filters_test.go#L807-L1069): https://storage.googleapis.com/k8s-triage/index.html?test=TestPodTopologySpreadFilter
496496

497497
**Score**
498-
- `k8s.io/kubernetes/test/integration/scheduler/scoring/priorities_test.go`: https://storage.googleapis.com/k8s-triage/index.html?test=TestPodTopologySpreadScoring
499-
500-
Also, we should make sure this feature brings no significant performance degradation in both Filter and Score.
501-
502-
- `k8s.io/kubernetes/test/integration/scheduler_perf/scheduler_perf_test.go`: https://storage.googleapis.com/k8s-triage/index.html?test=BenchmarkPerfScheduling
498+
- [`k8s.io/kubernetes/test/integration/scheduler/scoring/priorities_test.go`](https://github.com/kubernetes/kubernetes/blob/master/test/integration/scheduler/scoring/priorities_test.go#L383-L643): https://storage.googleapis.com/k8s-triage/index.html?test=TestPodTopologySpreadScoring
503499

504500
##### e2e tests
505501

@@ -761,8 +757,9 @@ will rollout across nodes.
761757
It shouldn't impact already running workloads. It's an opt-in feature,
762758
and users need to set `matchLabelKeys` or `mismatchLabelKeys` field in PodAffinity or PodAntiAffinity to use this feature.
763759

764-
When this feature is disabled by the feature flag, the already created Pod's `matchLabelKeys`/`mismatchLabelKeys` (+ `labelSelector` generated from them) is kept.
765-
But, the newly created Pod's `matchLabelKeys` or `mismatchLabelKeys` field is silently dropped.
760+
When this feature is disabled by the feature flag,
761+
the already created Pod's `matchLabelKeys`/`mismatchLabelKeys` is kept and the `labelSelector` is not modified back.
762+
But, the newly created Pod's `matchLabelKeys` or `mismatchLabelKeys` field is ignored and silently dropped.
766763

767764
###### What specific metrics should inform a rollback?
768765

@@ -989,7 +986,7 @@ Think about adding additional work or introducing new steps in between
989986

990987
Yes. there is an additional work: kube-apiserver uses the keys in `matchLabelKeys` or `mismatchLabelKeys` to look up label values from the pod,
991988
and change `labelSelector` according to them.
992-
Maybe result in a very small impact in the latency of pod creation request in kube-apiserver.
989+
The impact in the latency of pod creation request in kube-apiserver should be negligible.
993990

994991
###### Will enabling / using this feature result in non-negligible increase of resource usage (CPU, RAM, disk, IO, ...) in any components?
995992

0 commit comments

Comments
 (0)